Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12430

Implement simple distortions in matchPessimisticB

    Details

    • Story Points:
      10
    • Epic Link:
    • Sprint:
      Alert Production F17 - 10, Alert Production F17 - 11
    • Team:
      Alert Production

      Description

      The pervious version of matchPessimisiticB did not allow for distortions in the 3D rotation matrix applied to the source and reference datasets before matching. Adding such an allowance improves the quality of the associated sources and references sent to the astrometry fitter, improving matchAndFit performance.

      This ticket encapsulates work done on the u/morriscb/testMatcherDistortion, implementing this and also simplifying the heuristics in matchPessimisticB.

        Attachments

          Issue Links

            Activity

            Hide
            cmorrison Chris Morrison added a comment -

            Hey John Swinbank, I'll see what I can do with the rebasing. Do you want to sit down sometime tomorrow afternoon, after I've initially parsed your comments and chat about algorithm?

            Show
            cmorrison Chris Morrison added a comment - Hey John Swinbank , I'll see what I can do with the rebasing. Do you want to sit down sometime tomorrow afternoon, after I've initially parsed your comments and chat about algorithm?
            Hide
            swinbank John Swinbank added a comment -

            Works for me!

            Show
            swinbank John Swinbank added a comment - Works for me!
            Hide
            cmorrison Chris Morrison added a comment -

            Finished response to first round of comments. Additionally I added a new unittest to test_pessemisticPatternMatcher3D.py to test as requested.

            Show
            cmorrison Chris Morrison added a comment - Finished response to first round of comments. Additionally I added a new unittest to test_pessemisticPatternMatcher3D.py to test as requested.
            Hide
            swinbank John Swinbank added a comment -

            Nice test — thank you!

            I'm happy for you to go ahead and merge this without going back and undoing all the code formatting changes, etc. For next time, though, we'll keep them on separate commits as we discussed.

            Show
            swinbank John Swinbank added a comment - Nice test — thank you! I'm happy for you to go ahead and merge this without going back and undoing all the code formatting changes, etc. For next time, though, we'll keep them on separate commits as we discussed.
            Hide
            cmorrison Chris Morrison added a comment -

            Jenkins'ed code and merged into the stack.

            Show
            cmorrison Chris Morrison added a comment - Jenkins'ed code and merged into the stack.

              People

              • Assignee:
                cmorrison Chris Morrison
                Reporter:
                cmorrison Chris Morrison
                Reviewers:
                John Swinbank
                Watchers:
                Chris Morrison, Eric Bellm, Jim Bosch, John Swinbank
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: