# re-Verify performance of matchPessimistcB with new distorations

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
10
• Sprint:
Alert Production F17 - 10, Alert Production F17 - 11, AP S18-1, AP S18-2
• Team:

#### Description

Verify the matching performance of the matchPessimisticB code with simplified matching heuristics and rotation matrix distortion allowances.

This will be run on the same data set and visits as DM-9751 namely: HSC (3358), DECam (406285, 410827), CFHT (793169, 896070, 980526).

#### Activity

Hide
Chris Morrison [X] (Inactive) added a comment -

Work began on this at the beginning of the F17-10 sprint and should wrap up near the end/start of the month of October.

Show
Chris Morrison [X] (Inactive) added a comment - Work began on this at the beginning of the F17-10 sprint and should wrap up near the end/start of the month of October.
Hide
John Swinbank added a comment -

Mostly minor comments on the PR.

I think you could tweak the comments (for accuracy) and the variable names (for helpfulness) a little.

I'm also confused by the values of low and high in the call to sigmaclip. That might just be my misunderstanding, though, so I'd appreciate it if you could fill me in on the thinking.

Other than that, good to go.

Show
John Swinbank added a comment - Mostly minor comments on the PR. I think you could tweak the comments (for accuracy) and the variable names (for helpfulness) a little. I'm also confused by the values of low and high in the call to sigmaclip. That might just be my misunderstanding, though, so I'd appreciate it if you could fill me in on the thinking. Other than that, good to go.
Hide
Chris Morrison [X] (Inactive) added a comment -

Completed review, Jeniks, and merged.

Show
Chris Morrison [X] (Inactive) added a comment - Completed review, Jeniks, and merged.

#### People

Assignee:
Chris Morrison [X] (Inactive)
Reporter:
Chris Morrison [X] (Inactive)
Reviewers:
John Swinbank
Watchers:
Chris Morrison [X] (Inactive), Eric Bellm, John Swinbank