XMLWordPrintable

## Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
2
• Sprint:
AP S18-1
• Team:

## Description

Ian Sullivan has done a bunch of math for calculating things related to refraction. Some of these should live in VisitInfo, since it knows the necessary values for the calculations. In particular, visitInfo::getParallacticAngle() would be very helpful. I suspect that there are some others in his DCR code that we'd like to have more broadly available.

Ian suggests that he could do this as a pair coding exercise with Russell Owen or Krzysztof Findeisen, since he doesn't know C++ that well.

## Activity

Hide
John Parejko added a comment -

Note that I added a version of this calculation to jointcal::CcdImage.cc that should be replaced once it's in VisitInfo. There's a note for the relevant lines.

Show
John Parejko added a comment - Note that I added a version of this calculation to jointcal::CcdImage.cc that should be replaced once it's in VisitInfo. There's a note for the relevant lines.
Hide
Ian Sullivan added a comment -

This is a fairly simple addition to VisitInfo, that simply adds a function to compute the parallactic angle at the boresight of an exposure on the fly. It does not add that information to the metadata, though, because that is beyond my current need, and when I tried it generated a lot of errors when running scons on afw. I am not very familiar with C++, so please check everything over very carefully!

Show
Ian Sullivan added a comment - This is a fairly simple addition to VisitInfo, that simply adds a function to compute the parallactic angle at the boresight of an exposure on the fly. It does not add that information to the metadata, though, because that is beyond my current need, and when I tried it generated a lot of errors when running scons on afw. I am not very familiar with C++, so please check everything over very carefully!
Hide
Russell Owen added a comment -

I asked for a few changes on github: primarily a unit test and more documentation as to what the returned angle measures. Aside from that it looks good – clean code and a useful addition.

Show
Russell Owen added a comment - I asked for a few changes on github: primarily a unit test and more documentation as to what the returned angle measures. Aside from that it looks good – clean code and a useful addition.
Hide
Ian Sullivan added a comment -

The new function is VisitInfo.getBoresightParAngle().

Show
Ian Sullivan added a comment - The new function is VisitInfo.getBoresightParAngle().

## People

• Assignee:
Ian Sullivan
Reporter:
John Parejko
Reviewers:
Russell Owen
Watchers:
Ian Sullivan, John Parejko, John Swinbank, Krzysztof Findeisen, Russell Owen