Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12521

Update boost to 1.66

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: boost
    • Labels:
      None

      Attachments

        Issue Links

          Activity

          Hide
          fritzm Fritz Mueller added a comment -

          Passes CI except:

          On Centos6 with devtoolset-3, a couple of boost::unit based unit tests segv on exit after they print "*** No errors detected". Everything fine on Centos7 and OSX. Suspicion is that something in current boost::unit does not get along with gcc 4.9. Tried again on Centos6 with devtoolset-6, and everything was fine. Blocking now and will resume when CI is rolled forward onto devtoolset-6...

          Show
          fritzm Fritz Mueller added a comment - Passes CI except : On Centos6 with devtoolset-3, a couple of boost::unit based unit tests segv on exit after they print "*** No errors detected". Everything fine on Centos7 and OSX. Suspicion is that something in current boost::unit does not get along with gcc 4.9. Tried again on Centos6 with devtoolset-6, and everything was fine. Blocking now and will resume when CI is rolled forward onto devtoolset-6...
          Hide
          fritzm Fritz Mueller added a comment -

          Passes CI now in the devtoolset-6 era on all platforms. Some minor parallel changes required to afw.

          Show
          fritzm Fritz Mueller added a comment - Passes CI now in the devtoolset-6 era on all platforms. Some minor parallel changes required to afw.
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          Looks good, although I'm somewhat surprised it segfaulted in the first place.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Looks good, although I'm somewhat surprised it segfaulted in the first place.
          Hide
          tjenness Tim Jenness added a comment -

          Looks fine to me. Remember to tag after merging.

          Show
          tjenness Tim Jenness added a comment - Looks fine to me. Remember to tag after merging.
          Hide
          krzys Krzysztof Findeisen added a comment -

          Sorry, but I don't think I understand the patch file well enough to give a meaningful review.

          Show
          krzys Krzysztof Findeisen added a comment - Sorry, but I don't think I understand the patch file well enough to give a meaningful review.

            People

            Assignee:
            fritzm Fritz Mueller
            Reporter:
            fritzm Fritz Mueller
            Reviewers:
            Pim Schellart [X] (Inactive), Tim Jenness
            Watchers:
            Fritz Mueller, Krzysztof Findeisen, Pim Schellart [X] (Inactive), Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: