Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12524

AST should still write in FITS-WCS format after offsetting CRPIX

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      Alert Production F17 - 11, AP S18-1
    • Team:
      Alert Production

      Description

      If I offset CRPIX by inserting a shift at the beginning of the GRID to IWC mapping, the resulting WCS cannot be written in FITS-WCS format. David Berry has a fix in AST.

      This will require a new unit test in astshim and enables an improvement in ast: the shift can be added after GRID instead of between PIXEL0 and GRID (breaking the desired rule that PIXEL0 to GRID is always a shift of +1).

        Attachments

          Issue Links

            Activity

            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Epic Link DM-3875 [ 20170 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-10765 [ DM-10765 ]
            rowen Russell Owen made changes -
            Story Points 2 1
            Hide
            rowen Russell Owen added a comment -

            Changes in starlink_ast: I merged updates from David Berry. Please check that the merge looks sane.

            Changes in astshim:

            • Add support for a new parameter FitsTol to FitsChan.
            • Add two tests to test_FitsChan.py: one for FitsTol and one for the bug this ticket addresses.
            Show
            rowen Russell Owen added a comment - Changes in starlink_ast: I merged updates from David Berry. Please check that the merge looks sane. Changes in astshim: Add support for a new parameter FitsTol to FitsChan . Add two tests to test_FitsChan.py: one for FitsTol and one for the bug this ticket addresses.
            rowen Russell Owen made changes -
            Reviewers Tim Jenness [ tjenness ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            Hide
            tjenness Tim Jenness added a comment -

            These changes look okay. I worry we need to change the way we merge upstream changes into lsst-dev but that doesn't affect the current ticket.

            You might want to set the assignee of this ticket.

            Show
            tjenness Tim Jenness added a comment - These changes look okay. I worry we need to change the way we merge upstream changes into lsst-dev but that doesn't affect the current ticket. You might want to set the assignee of this ticket.
            tjenness Tim Jenness made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            rowen Russell Owen made changes -
            Assignee Russell Owen [ rowen ]
            swinbank John Swinbank made changes -
            Sprint Alert Production F17 - 11 [ 644 ] Alert Production F17 - 11, AP S18-1 [ 644, 669 ]
            swinbank John Swinbank made changes -
            Rank Ranked higher
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Tim Jenness
                Watchers:
                Russell Owen, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel