Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12557

False positives when testing for pipeline completion

    Details

      Description

      ap_pipe tests whether pipeline steps have been completed, and runs them only if they have not. However, errors in a pipeline step may cause it to appear completed when it is not. Two cases have been detected so far:

      • an AttributeError (from mismatched pipeline versions) in an obs package is silently ignored during ingestion, causing no data to be loaded. Re-running the pipeline skips data ingestion.
      • an exception during metadata handling causes a pipeline abort. Re-running the pipeline skips the step, so no metadata from it are available.

      It would be appreciated if the checks could be made a little more conservative, so that a step is only skipped if it is definitely finished.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment -

            As a closely related issue, the completion checks should be able to tell if the pipeline was run for the same CCD or not.

            Show
            krzys Krzysztof Findeisen added a comment - As a closely related issue, the completion checks should be able to tell if the pipeline was run for the same CCD or not.
            Hide
            krzys Krzysztof Findeisen added a comment -

            As part of DM-13163 the skip checks were rewritten in terms of Butler repository queries, fixing both the false positives and the inability to discriminate between CCDs. It can be closed once the fix is confirmed and DM-13163 is merged.

            Show
            krzys Krzysztof Findeisen added a comment - As part of DM-13163 the skip checks were rewritten in terms of Butler repository queries, fixing both the false positives and the inability to discriminate between CCDs. It can be closed once the fix is confirmed and DM-13163 is merged.
            Hide
            krzys Krzysztof Findeisen added a comment - - edited

            Obsolete after DM-13163.

            Show
            krzys Krzysztof Findeisen added a comment - - edited Obsolete after DM-13163 .

              People

              • Assignee:
                mrawls Meredith Rawls
                Reporter:
                krzys Krzysztof Findeisen
                Watchers:
                Krzysztof Findeisen
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: