Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12594

Remove daf::base::Citizen

    XMLWordPrintable

    Details

      Description

      Remove daf::base::Citizen and all use of it.

      I'm calling this a SciencePipelines ticket since the vast majority of the usage is in afw.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-19461 Investigate and possibly fix afw::table Record allocation performance`

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-280 Remove or disable daf::base::Citizen

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            6 older comments
            Hide
            Permalink
            nlust Nate Lust added a comment -

            I will start looking at this review today, sorry for the delay. Is there anything you want me to pay attention to in detail? I skimmed it and as you say most of it is just standard changes.

            Show
            nlust Nate Lust added a comment - I will start looking at this review today, sorry for the delay. Is there anything you want me to pay attention to in detail? I skimmed it and as you say most of it is just standard changes.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            As I say in the comment above, the unittests where I removed some of the tests are probably the most important thing.

            Show
            Parejkoj John Parejko added a comment - As I say in the comment above, the unittests where I removed some of the tests are probably the most important thing.
            Hide
            Permalink
            nlust Nate Lust added a comment -

            Will do. I guess I was trying to ask if there was anything in particular in the library code as well, and just did it poorly.

            Show
            nlust Nate Lust added a comment - Will do. I guess I was trying to ask if there was anything in particular in the library code as well, and just did it poorly.
            Hide
            Permalink
            nlust Nate Lust added a comment -

            A few minor comments, but looks good

            Show
            nlust Nate Lust added a comment - A few minor comments, but looks good
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thank you for taking on this big review, Nate Lust.

            With this, Citizen is now gone for good!

            Show
            Parejkoj John Parejko added a comment - Thank you for taking on this big review, Nate Lust . With this, Citizen is now gone for good!

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Nate Lust
              Watchers:
              Jim Bosch, John Parejko, Krzysztof Findeisen, Nate Lust, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.