Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12740

afw::geom::Transform should be Persistable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Story Points:
      2
    • Sprint:
      DRP S18-1, DRP S18-2
    • Team:
      Data Release Production

      Description

      In order to be usable as a component of other Persistable objects, afw::geom::Transform should be persistable.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Russell Owen, is this already planned as part of DM-10765? If so, and the ETA for that landing isn't early next week, I'd like to discuss trying to get those changes onto this ticket and earlier. If not, we should probably discuss how I can do this without disrupting your work on SkyWcs.

            Show
            jbosch Jim Bosch added a comment - Russell Owen , is this already planned as part of DM-10765 ? If so, and the ETA for that landing isn't early next week, I'd like to discuss trying to get those changes onto this ticket and earlier. If not, we should probably discuss how I can do this without disrupting your work on SkyWcs.
            Hide
            rowen Russell Owen added a comment -

            It wasn't on my radar for DM-10765

            Show
            rowen Russell Owen added a comment - It wasn't on my radar for DM-10765
            Hide
            jbosch Jim Bosch added a comment -

            Russell Owen, just a heads-up that I'm going to start on this now, since DM-12764 has landed and I think that I can both get it done before DM-10765 lands and it should be an easy rebase for you - and getting it done first will save us from having to worry about whether to write a backwards compatibility layer for SkyWcss written before this ticket (since I assume we won't have persisted any that matter until DM-10765 lands).

            Show
            jbosch Jim Bosch added a comment - Russell Owen , just a heads-up that I'm going to start on this now, since DM-12764 has landed and I think that I can both get it done before DM-10765 lands and it should be an easy rebase for you - and getting it done first will save us from having to worry about whether to write a backwards compatibility layer for SkyWcss written before this ticket (since I assume we won't have persisted any that matter until DM-10765 lands).
            Hide
            rowen Russell Owen added a comment -

            That seems fine. I'll just ask you to avoid unnecessary changes (such as running clang-tidy).

            Show
            rowen Russell Owen added a comment - That seems fine. I'll just ask you to avoid unnecessary changes (such as running clang-tidy).
            Hide
            jbosch Jim Bosch added a comment -

            All changes in afw, and it's basically just a copy of the old SkyWcs persistence. Jenkins run is in progress.

            Show
            jbosch Jim Bosch added a comment - All changes in afw, and it's basically just a copy of the old SkyWcs persistence. Jenkins run is in progress.
            Hide
            rowen Russell Owen added a comment -

            Looks great. One request for a new free function.

            Show
            rowen Russell Owen added a comment - Looks great. One request for a new free function.
            Hide
            jbosch Jim Bosch added a comment -

            Merged to master.

            Show
            jbosch Jim Bosch added a comment - Merged to master.

              People

              • Assignee:
                jbosch Jim Bosch
                Reporter:
                jbosch Jim Bosch
                Reviewers:
                Russell Owen
                Watchers:
                Jim Bosch, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel