Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      20
    • Epic Link:
    • Sprint:
      Alert Production F17 - 11, AP S18-1
    • Team:
      Alert Production

      Description

      As part of DM-10765 it became apparently that SkyWcs needed many changes, including:

      • Do not inherit from Transform
      • Add FITS binary table persistence
      • Add missing functionality as methods or free functions

      In addition, it is possible to greatly simplify the code using the new ast::FrameDict class.

      Jim Bosch suggested, and I agree, that it is better to do the SkyWcs overhaul on a ticket separate than DM-10765, making DM-10765 itself smaller and more focused.

        Attachments

          Issue Links

            Activity

            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Epic Link DM-9679 [ 30784 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-10765 [ DM-10765 ]
            swinbank John Swinbank made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-12771 [ DM-12771 ]
            Hide
            rowen Russell Owen added a comment -

            As suggested by John Swinbank, I would like you two to review this as follows:

            Changes include:

            • Functions that returned a SkyWcs or Transform now return a shared_ptr. This includes readString, readStream, then and makeWcsPairTransform
            • New functions to construct a (shared pointer to) SkyWcs, such as makeTanSipWcs and makeModifiedWcs
            • SkyWcs(crpix, crval, ...) now has a projection argument which defaults to Tan
            • A new set of functions in wcsUtils

            All this work was done in support of DM-10765, which makes use of this new functionality.

            Show
            rowen Russell Owen added a comment - As suggested by John Swinbank , I would like you two to review this as follows: Detailed review by Krzysztof Findeisen Examine the API by Jim Bosch Changes include: Functions that returned a SkyWcs or Transform now return a shared_ptr. This includes readString, readStream, then and makeWcsPairTransform New functions to construct a (shared pointer to) SkyWcs, such as makeTanSipWcs and makeModifiedWcs SkyWcs(crpix, crval, ...) now has a projection argument which defaults to Tan A new set of functions in wcsUtils All this work was done in support of DM-10765 , which makes use of this new functionality.
            rowen Russell Owen made changes -
            Reviewers Jim Bosch, Krzysztof Findeisen [ jbosch, krzys ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            swinbank John Swinbank made changes -
            Sprint Alert Production F17 - 11 [ 644 ] Alert Production F17 - 11, AP S18-1 [ 644, 669 ]
            swinbank John Swinbank made changes -
            Rank Ranked higher
            Hide
            krzys Krzysztof Findeisen added a comment -

            Done with my portion.

            Show
            krzys Krzysztof Findeisen added a comment - Done with my portion.
            krzys Krzysztof Findeisen made changes -
            Reviewers Jim Bosch, Krzysztof Findeisen [ jbosch, krzys ] Jim Bosch [ jbosch ]
            rowen Russell Owen made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            rowen Russell Owen made changes -
            Link This issue blocks DM-10765 [ DM-10765 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-10765 [ DM-10765 ]
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            hchiang2 Hsin-Fang Chiang made changes -
            Link This issue is triggering DM-13062 [ DM-13062 ]

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Jim Bosch
                Watchers:
                Jim Bosch, Krzysztof Findeisen, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: