Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12771

Support the new FitsChan SipReplace attribute

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: astshim
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      Alert Production F17 - 11
    • Team:
      Alert Production

      Description

      Add support for the new FitsChan attribute SipReplace. This makes AST believe the inverse SIP coefficients and will be usable in DM-12764 to improve the accuracy of SkyWcs.skyToPixels for WCS with SIP terms.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            The starlink_ast changes need no review; if they pass Jenkins then that's fine.

            Show
            rowen Russell Owen added a comment - The starlink_ast changes need no review; if they pass Jenkins then that's fine.
            Hide
            Parejkoj John Parejko added a comment -

            Looks fine. One minor comment re: docstring for your new test.

            Show
            Parejkoj John Parejko added a comment - Looks fine. One minor comment re: docstring for your new test.
            Hide
            rowen Russell Owen added a comment -

            Thank you for the quick review. I added the requested doc string.

            Show
            rowen Russell Owen added a comment - Thank you for the quick review. I added the requested doc string.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                John Parejko
                Watchers:
                John Parejko, Russell Owen, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: