# Add source selection by signal-to-noise ratio

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Team:
External

#### Description

Masayuki Tanaka suggests that photoCal might benefit from a signal-to-noise cut.

#### Activity

Hide
Paul Price added a comment -

Lauren MacArthur, would you mind reviewing this please? It's not urgent (so please don't waste time on it over the holiday weekend), but I'd like it to go into the next HSC release (targeting December 5).

 price@byoung2013:~/LSST/meas_algorithms (tickets/DM-12798=) $git sub commit 4dbd1a09a9cadf8fa6f948c95dff15130b6df870 Author: Paul Price  Date: Wed Nov 22 20:48:19 2017 -0500    sourceSelector: factor out min/max limits    The various source selection modules have had common code to apply  minimum and maximum limits. Factor this common code into a base class.    python/lsst/meas/algorithms/sourceSelector.py | 79 ++++++++++++++++-----------  1 file changed, 47 insertions(+), 32 deletions(-)   commit a862090054b00431a2b8c6d3927104c36eda2d29 Author: Paul Price  Date: Wed Nov 22 20:48:52 2017 -0500    sourceSelector: add selection by signal-to-noise    Masayuki Tanaka (NAOJ) suggested that a signal-to-noise ratio limit would  be a useful addition.    python/lsst/meas/algorithms/sourceSelector.py | 46 +++++++++++++++++++++++++++  tests/test_sourceSelector.py | 18 +++++++++++  2 files changed, 64 insertions(+)   commit 297ac191b4cf2637f7396fbd0f98052c39bb8a74 (HEAD -> tickets/DM-12798, origin/tickets/DM-12798) Author: Paul Price  Date: Wed Nov 22 21:10:50 2017 -0500    git: ignore pytest_session.txt    File generated by pytest.    .gitignore | 3 ++-  1 file changed, 2 insertions(+), 1 deletion(-)  Show Paul Price added a comment - Lauren MacArthur , would you mind reviewing this please? It's not urgent (so please don't waste time on it over the holiday weekend), but I'd like it to go into the next HSC release (targeting December 5). price@byoung2013:~/LSST/meas_algorithms (tickets/DM-12798=)$ git sub commit 4dbd1a09a9cadf8fa6f948c95dff15130b6df870 Author: Paul Price <price@astro.princeton.edu> Date: Wed Nov 22 20:48:19 2017 -0500   sourceSelector: factor out min/max limits The various source selection modules have had common code to apply minimum and maximum limits. Factor this common code into a base class.   python/lsst/meas/algorithms/sourceSelector.py | 79 ++++++++++++++++----------- 1 file changed, 47 insertions(+), 32 deletions(-)   commit a862090054b00431a2b8c6d3927104c36eda2d29 Author: Paul Price <price@astro.princeton.edu> Date: Wed Nov 22 20:48:52 2017 -0500   sourceSelector: add selection by signal-to-noise Masayuki Tanaka (NAOJ) suggested that a signal-to-noise ratio limit would be a useful addition.   python/lsst/meas/algorithms/sourceSelector.py | 46 +++++++++++++++++++++++++++ tests/test_sourceSelector.py | 18 +++++++++++ 2 files changed, 64 insertions(+)   commit 297ac191b4cf2637f7396fbd0f98052c39bb8a74 (HEAD -> tickets/DM-12798, origin/tickets/DM-12798) Author: Paul Price <price@astro.princeton.edu> Date: Wed Nov 22 21:10:50 2017 -0500   git: ignore pytest_session.txt File generated by pytest.   .gitignore | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Hide
Paul Price added a comment -

Jenkins is green.

Show
Paul Price added a comment - Jenkins is green.
Hide
Lauren MacArthur added a comment -

A few comments on the PR. Otherwise, looks good.

Show
Lauren MacArthur added a comment - A few comments on the PR. Otherwise, looks good.
Hide
Paul Price added a comment -

Something else to think about: John Parejko points out "that change does require that the refcat has flux errors".

Show
Paul Price added a comment - Something else to think about: John Parejko points out "that change does require that the refcat has flux errors".
Hide
Paul Price added a comment -

Thanks Lauren! I believe I've dealt with all the comments on the GitHub PR, and I've added a MagnitudeErrorLimit to function as a signal-to-noise limit for magnitudes. I'm going to run this through Jenkins and merge if all goes well.

Show
Paul Price added a comment - Thanks Lauren! I believe I've dealt with all the comments on the GitHub PR, and I've added a MagnitudeErrorLimit to function as a signal-to-noise limit for magnitudes. I'm going to run this through Jenkins and merge if all goes well.
Hide
Paul Price added a comment -

Jenkins passed in aggregate: 27167 has centos7-py3 passing and the others failing, while 27171 has the same one failing and the others passing. I believe the failures are due to the Jenkins system, and the fact that each element has passed in one run or the other indicates it's safe to merge.

Show
Paul Price added a comment - Jenkins passed in aggregate: 27167 has centos7-py3 passing and the others failing, while 27171 has the same one failing and the others passing. I believe the failures are due to the Jenkins system, and the fact that each element has passed in one run or the other indicates it's safe to merge.
Hide
Paul Price added a comment -

Merged to master.

Show
Paul Price added a comment - Merged to master.

#### People

Assignee:
Paul Price
Reporter:
Paul Price
Reviewers:
Lauren MacArthur
Watchers:
John Parejko, Lauren MacArthur, Paul Price