Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1283

remove meas_extensions_multiShapelet from release packages/buildbot

    XMLWordPrintable

    Details

      Attachments

        Activity

        Hide
        jbosch Jim Bosch added a comment -

        Frossie, entirely trivial code review for you:

        lsst_apps:u/jbosch/DM-1283 % git show
        commit d9cac129b6ea7ae4faaa5a4c99b2e19c305916b0
        Author: Jim Bosch <jbosch@astro.princeton.edu>
        Date:   Mon Oct 6 13:52:10 2014 -0400
         
            Remove meas_extensions_multiShapelet from dependencies
         
        diff --git a/ups/lsst_apps.table b/ups/lsst_apps.table
        index d5f8895..3790d36 100644
        --- a/ups/lsst_apps.table
        +++ b/ups/lsst_apps.table
        @@ -1,6 +1,5 @@
         setupRequired(lsst_libs)
         setupRequired(meas_deblender)
        -setupRequired(meas_extensions_multiShapelet)
         setupRequired(pipe_tasks)
         setupRequired(obs_lsstSim)
         setupRequired(obs_sdss)

        I'm mostly just looking for your sign-off that:

        • this would be a non-disruptive time to merge this change to master
        • there's nothing else I need to do to remove this package from buildbot and eups distrib releases.
        Show
        jbosch Jim Bosch added a comment - Frossie, entirely trivial code review for you: lsst_apps:u/jbosch/DM-1283 % git show commit d9cac129b6ea7ae4faaa5a4c99b2e19c305916b0 Author: Jim Bosch <jbosch@astro.princeton.edu> Date: Mon Oct 6 13:52:10 2014 -0400   Remove meas_extensions_multiShapelet from dependencies   diff --git a/ups/lsst_apps.table b/ups/lsst_apps.table index d5f8895..3790d36 100644 --- a/ups/lsst_apps.table +++ b/ups/lsst_apps.table @@ -1,6 +1,5 @@ setupRequired(lsst_libs) setupRequired(meas_deblender) -setupRequired(meas_extensions_multiShapelet) setupRequired(pipe_tasks) setupRequired(obs_lsstSim) setupRequired(obs_sdss) I'm mostly just looking for your sign-off that: this would be a non-disruptive time to merge this change to master there's nothing else I need to do to remove this package from buildbot and eups distrib releases.
        Hide
        frossie Frossie Economou added a comment -

        Looks good - and I believe that's all you need to do. Do you want me to backport this change to S14? Or is it going forward only?

        Show
        frossie Frossie Economou added a comment - Looks good - and I believe that's all you need to do. Do you want me to backport this change to S14? Or is it going forward only?
        Hide
        jbosch Jim Bosch added a comment -

        Do you want me to backport this change to S14? Or is it going forward only?

        Going forward only, though I plan to request an early W15 release that includes this in the next week or so, once a few more issues are in as well.

        Show
        jbosch Jim Bosch added a comment - Do you want me to backport this change to S14? Or is it going forward only? Going forward only, though I plan to request an early W15 release that includes this in the next week or so, once a few more issues are in as well.
        Hide
        jbosch Jim Bosch added a comment -

        Looks like this is still part of buildbot, so there must be something else I need to do.

        Show
        jbosch Jim Bosch added a comment - Looks like this is still part of buildbot, so there must be something else I need to do.
        Hide
        jbosch Jim Bosch added a comment -

        Found another (optional) dependency in obs_sdss, which I've now removed as well. Will close once I've confirmed that it's not part of buildbot.

        Show
        jbosch Jim Bosch added a comment - Found another (optional) dependency in obs_sdss, which I've now removed as well. Will close once I've confirmed that it's not part of buildbot.
        Hide
        jbosch Jim Bosch added a comment -

        Russell Owen helped out by removing this from the dependencies of datarel and testing_endToEnd, and I can now confirm that meas_extensions_multiShapelet is no longer being built by buildbot.

        Show
        jbosch Jim Bosch added a comment - Russell Owen helped out by removing this from the dependencies of datarel and testing_endToEnd, and I can now confirm that meas_extensions_multiShapelet is no longer being built by buildbot.

          People

          Assignee:
          jbosch Jim Bosch
          Reporter:
          jbosch Jim Bosch
          Reviewers:
          Frossie Economou
          Watchers:
          Frossie Economou, Jim Bosch
          Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

            Dates

            Created:
            Updated:
            Resolved:

              Jenkins

              No builds found.