Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12878

LSST's astrometry_net packages is not Python 3 compliant.

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: astrometry_net
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      AP S18-1, AP S18-2, AP S18-3, AP S18-4, AP S18-5, AP S18-6, AP F18-1, AP F18-2, AP F18-3, AP F18-4, AP F18-5
    • Team:
      Alert Production

      Description

      Krzysztof Suberlak is trying to use the text2fits.py utility provided by the Stack's astrometry_net package. Unfortunately, it doesn't work with Python 3:

      Reading file starfast_ref_obs_s5n6170.txt
      		 
      Column names: ['id', 'ra', 'dec', 'u', 'g', 'r', 'i', 'z', 'y']
      		 
      Traceback (most recent call last):
      		 
      File "/Users/chris/lsst_stack2/stack/miniconda3-4.3.21-10a4fa6/DarwinX86/astrometry_net/0.67.123ff3e.lsst1+4/bin/text2fits.py", line 50, in <module>
      		 
      intvalmap=inulls)
      		 
      File "/Users/chris/lsst_stack2/stack/miniconda3-4.3.21-10a4fa6/DarwinX86/astrometry_net/0.67.123ff3e.lsst1+4/lib/python/astrometry/util/fits.py", line 813, in streaming_text_table
      		 
      for i,line in zip(xrange(Nchunk), f):
      		 
      NameError: name 'xrange' is not defined

      Please fix it.

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-12869 builds of lsst_distrib fail with setuptools_scm errors

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Easy solution would be to update to a newer upstream from astrometry.net. Unfortunately, we can't test this until DM-12869 is resolved.

            Show
            swinbank John Swinbank added a comment - Easy solution would be to update to a newer upstream from astrometry.net. Unfortunately, we can't test this until DM-12869 is resolved.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Good news: the latest astrometry.net runs through Jenkins with no objections: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27152/pipeline/32/

            Bad news: the latest astrometry.net contains the same problematic use of xrange, so it's unlikely to actually solve this issue.

            Show
            swinbank John Swinbank added a comment - Good news: the latest astrometry.net runs through Jenkins with no objections: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27152/pipeline/32/ Bad news: the latest astrometry.net contains the same problematic use of xrange , so it's unlikely to actually solve this issue.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I'm sorry. When I worked on this I only patched the bits of astrometry.net that it looked like we were using. I wasn't in a position to test everything.

            Show
            tjenness Tim Jenness added a comment - I'm sorry. When I worked on this I only patched the bits of astrometry.net that it looked like we were using. I wasn't in a position to test everything.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            We no longer use astrometry_net so marking this as Won't Fix.

            Show
            tjenness Tim Jenness added a comment - We no longer use astrometry_net so marking this as Won't Fix.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              swinbank John Swinbank
              Watchers:
              Ian Sullivan, John Swinbank, Krzysztof Suberlak, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.