Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12882

Frequent catastrophic misalignment in coadd inputs

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_mosaic
    • Labels:
      None

      Description

      Catastrophically bad WCSs that print through to the coadd seem to have much more common between _42 (where they were basically nonexistent) and _46.

      This manifests both as duplicated sources and bad clipping.

        Attachments

          Activity

          Hide
          yusra Yusra AlSayyad added a comment -

          The 4 lines look good. I get that this is an emergency situation to get this working before the next weekly kicks off so by all means merge, but what about the lines you didn't fix like (the new) 136 - 140? Can we open another ticket to fully clean it up?

          Show
          yusra Yusra AlSayyad added a comment - The 4 lines look good. I get that this is an emergency situation to get this working before the next weekly kicks off so by all means merge, but what about the lines you didn't fix like (the new) 136 - 140? Can we open another ticket to fully clean it up?
          Hide
          yusra Yusra AlSayyad added a comment -

          Also where can I read about the compression change? Last night, I noticed that the old version of DS9 I was using on lsst-dev can't read the new image format. (I freaked out for a brief moment thinking _46 was even worse than it was )

          Show
          yusra Yusra AlSayyad added a comment - Also where can I read about the compression change? Last night, I noticed that the old version of DS9 I was using on lsst-dev can't read the new image format. (I freaked out for a brief moment thinking _46 was even worse than it was )
          Hide
          jbosch Jim Bosch added a comment -

          Lines 136-140 I somehow missed, and will now fix. I'll do another pass to make sure, but I think the remaining usage of calexp_md is for some special value Lauren MacArthur put in (or found in) the headers to check whether things are being read from hscPipe 4.x or earlier, and that should already be compression-safe.

          The main explanation of compression I know of is https://community.lsst.org/t/fits-tile-compression-support/2233.

          Show
          jbosch Jim Bosch added a comment - Lines 136-140 I somehow missed, and will now fix. I'll do another pass to make sure, but I think the remaining usage of calexp_md is for some special value Lauren MacArthur put in (or found in) the headers to check whether things are being read from hscPipe 4.x or earlier, and that should already be compression-safe. The main explanation of compression I know of is https://community.lsst.org/t/fits-tile-compression-support/2233 .
          Hide
          lauren Lauren MacArthur added a comment -

          Yep, the one I added is to check if the processing was done using any version of the now-obsolete HSC stack by checking for the HSCPIPE_VERSION fits header. We don’t really anticipate any further use case, but, regardless, any such run would long predate compression, so is, as Jim says, safe.

          Show
          lauren Lauren MacArthur added a comment - Yep, the one I added is to check if the processing was done using any version of the now-obsolete HSC stack by checking for the HSCPIPE_VERSION fits header. We don’t really anticipate any further use case, but, regardless, any such run would long predate compression, so is, as Jim says, safe.
          Hide
          jbosch Jim Bosch added a comment -

          Merged to master.

          Show
          jbosch Jim Bosch added a comment - Merged to master.

            People

            • Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Yusra AlSayyad
              Watchers:
              Jim Bosch, Lauren MacArthur, Yusra AlSayyad
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: