Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: validate_drp
-
Labels:
-
Story Points:4
-
Epic Link:
-
Team:Alert Production
Description
Building on validate_drp/reportPerformance.py, we need some code to take the JSON output of validate_drp on all of the tracts+filter combinations and produce some kind of summary table to compare the 115 tract+filter combinations across the three runs (singleFrame/jointcal/meas_mosaic) in photometry and astrometry. There's already some pretty-printing code in validate_drp that we can probably steal.
Attachments
Activity
Done; it's a Jupyter notebook, and it depends on a data.write("data.fits", format="fits") line I added to summarizePerformanceRst.py (but did not commit). So you may want to tinker with it a bit before merging to get into your workflow, but the code's all there.
Thanks for that. I pulled out the plotting code and put it into summarizePerformance.py and tweaked the style a bit: it now makes plots for all the metrics and prints a summary of ones that exceed the design spec (currently all PA1, and a couple of AM1).
Do you want to review my modified code, or are you happy with this now? My plan for the future is to run reportPerformance.py->summarizePerformanceRst.py on the output of my validate_drp jobs and post the output in DM-11785 once it looks decent.
I don't think I need to review the modified code if it's just being used to make the plots.
Thanks. I'll generate and upload all the plots to the relevant ticket once I'm happy with the photometry results. I definitely like the plot layout you came up with.
Thanks! Do you mind committing the code you wrote to make those plots to the jointcal_compare repo on this branch? Then I can just make them as soon as I've run validate_drp.