Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12906

Generate summary tables for jointcal/meas_mosaic comparison

    Details

      Description

      Building on validate_drp/reportPerformance.py, we need some code to take the JSON output of validate_drp on all of the tracts+filter combinations and produce some kind of summary table to compare the 115 tract+filter combinations across the three runs (singleFrame/jointcal/meas_mosaic) in photometry and astrometry. There's already some pretty-printing code in validate_drp that we can probably steal.

        Attachments

        1. AM1vAF1_HSC-G.png
          AM1vAF1_HSC-G.png
          29 kB
        2. AM1vAF1_HSC-I.png
          AM1vAF1_HSC-I.png
          30 kB
        3. AM1vAF1_HSC-R.png
          AM1vAF1_HSC-R.png
          31 kB
        4. AM1vAF1_HSC-Y.png
          AM1vAF1_HSC-Y.png
          31 kB
        5. AM1vAF1_HSC-Z.png
          AM1vAF1_HSC-Z.png
          33 kB

          Activity

          Hide
          Parejkoj John Parejko added a comment -

          Thanks! Do you mind committing the code you wrote to make those plots to the jointcal_compare repo on this branch? Then I can just make them as soon as I've run validate_drp.

          Show
          Parejkoj John Parejko added a comment - Thanks! Do you mind committing the code you wrote to make those plots to the jointcal_compare repo on this branch? Then I can just make them as soon as I've run validate_drp.
          Hide
          jbosch Jim Bosch added a comment -

          Done; it's a Jupyter notebook, and it depends on a data.write("data.fits", format="fits") line I added to summarizePerformanceRst.py (but did not commit). So you may want to tinker with it a bit before merging to get into your workflow, but the code's all there.

          Show
          jbosch Jim Bosch added a comment - Done; it's a Jupyter notebook, and it depends on a data.write("data.fits", format="fits") line I added to summarizePerformanceRst.py (but did not commit). So you may want to tinker with it a bit before merging to get into your workflow, but the code's all there.
          Hide
          Parejkoj John Parejko added a comment - - edited

          Thanks for that. I pulled out the plotting code and put it into summarizePerformance.py and tweaked the style a bit: it now makes plots for all the metrics and prints a summary of ones that exceed the design spec (currently all PA1, and a couple of AM1).

          Do you want to review my modified code, or are you happy with this now? My plan for the future is to run reportPerformance.py->summarizePerformanceRst.py on the output of my validate_drp jobs and post the output in DM-11785 once it looks decent.

          Show
          Parejkoj John Parejko added a comment - - edited Thanks for that. I pulled out the plotting code and put it into summarizePerformance.py and tweaked the style a bit: it now makes plots for all the metrics and prints a summary of ones that exceed the design spec (currently all PA1, and a couple of AM1). Do you want to review my modified code, or are you happy with this now? My plan for the future is to run reportPerformance.py -> summarizePerformanceRst.py on the output of my validate_drp jobs and post the output in DM-11785 once it looks decent.
          Hide
          jbosch Jim Bosch added a comment -

          I don't think I need to review the modified code if it's just being used to make the plots.

          Show
          jbosch Jim Bosch added a comment - I don't think I need to review the modified code if it's just being used to make the plots.
          Hide
          Parejkoj John Parejko added a comment -

          Thanks. I'll generate and upload all the plots to the relevant ticket once I'm happy with the photometry results. I definitely like the plot layout you came up with.

          Show
          Parejkoj John Parejko added a comment - Thanks. I'll generate and upload all the plots to the relevant ticket once I'm happy with the photometry results. I definitely like the plot layout you came up with.

            People

            • Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, John Parejko, John Swinbank, Lauren MacArthur, Michael Wood-Vasey
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel