Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12918

investigate and merge u/fix_outliers

    XMLWordPrintable

    Details

      Description

      Pierre Astier added work in u/fix_outliers to better manage photometry errors and outlier rejection. This ticket is to review that work and see if it fixes the problems with HSC processing on the constrained model.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            Dominique Boutigny also add some work on color terms to the above ticket, but that is going to be more complicated to merge (we now have reference S/N selectors thanks to Paul Price, which I'd rather use). I'll move that work to a different ticket, to make the review easier.

            I've got Pierre Astier's outlier rejection and error freezing changes in this ticket branch and the test metrics updated to match (though I should add a test specifically for photometryModel.freezeErrorScales) and I'm now reprocessing HSC PDR1 on that branch. Just using the outlier rejection fix got a lot more of the HSC photometry fitting to work, so that's a good start.

            Show
            Parejkoj John Parejko added a comment - Dominique Boutigny also add some work on color terms to the above ticket, but that is going to be more complicated to merge (we now have reference S/N selectors thanks to Paul Price , which I'd rather use). I'll move that work to a different ticket, to make the review easier. I've got Pierre Astier 's outlier rejection and error freezing changes in this ticket branch and the test metrics updated to match (though I should add a test specifically for photometryModel.freezeErrorScales ) and I'm now reprocessing HSC PDR1 on that branch. Just using the outlier rejection fix got a lot more of the HSC photometry fitting to work, so that's a good start.
            Hide
            Parejkoj John Parejko added a comment - - edited

            Fred Moolekamp: are you able to review this? It's about +200/-90, mostly C++.

            I'm curious what you think of my method of dealing with the base class logging namespace issue (i.e., getting the baseclass methods to log to the subclass logging namespace). I don't know if there's a preferred approach.

            Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27197/pipeline

            Show
            Parejkoj John Parejko added a comment - - edited Fred Moolekamp : are you able to review this? It's about +200/-90 , mostly C++. I'm curious what you think of my method of dealing with the base class logging namespace issue (i.e., getting the baseclass methods to log to the subclass logging namespace). I don't know if there's a preferred approach. Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27197/pipeline
            Hide
            fred3m Fred Moolekamp added a comment -

            Looks good. See minor comments in PR.

            Show
            fred3m Fred Moolekamp added a comment - Looks good. See minor comments in PR.
            Hide
            Parejkoj John Parejko added a comment -
            Show
            Parejkoj John Parejko added a comment - New Jenkins run: https://ci.lsst.codes/job/stack-os-matrix/27217/
            Hide
            Parejkoj John Parejko added a comment -

            New new jenkins run (forgot to update one chi2 value): https://ci.lsst.codes/job/stack-os-matrix/27219/

            Show
            Parejkoj John Parejko added a comment - New new jenkins run (forgot to update one chi2 value): https://ci.lsst.codes/job/stack-os-matrix/27219/
            Hide
            Parejkoj John Parejko added a comment -

            Thanks for the review comments: you helped me find and fix a bug!

            Squashed, merged, and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the review comments: you helped me find and fix a bug! Squashed, merged, and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Fred Moolekamp
              Watchers:
              Dominique Boutigny, Fred Moolekamp, John Parejko, John Swinbank, Pierre Astier
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: