Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12924

SpherePoint.offset should work at the poles and for negative offsets

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      AP S18-2
    • Team:
      Alert Production

      Description

      In replacing Coord with SpherePoint (DM-11162) I discovered a problem in the skymap package: skymap makes heavy use of Coord.offset, including for points at a pole. However, SpherePoint rejects such offsets (as well as negative offsets).

      I believe the behavior of offset for a coord at the pole is unambiguous and unsurprising if the coord is constructed from longitude, latitude. However, I acknowledge that this is less so for a coord constructed from a 3-vector. Nonetheless, I propose to change the behavior of SpherePoint to match Coord and document the behavior at the pole.

      I also propose to allow negative offsets, as the intent is unambiguous for those and Coord supports it.

      Also make sure the sign convention for the orientation of offset is the same for SpherePoint as Coord and document it carefully.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment -

            Looks much better now, only some minor comments.

            Show
            krzys Krzysztof Findeisen added a comment - Looks much better now, only some minor comments.
            Hide
            krzys Krzysztof Findeisen added a comment -

            Hi Russell Owen, the code looks fine, but the documentation needs to be updated, and I'd really like to see some tests of offset and bearingTo at the poles before I sign off on the merge.

            Show
            krzys Krzysztof Findeisen added a comment - Hi Russell Owen , the code looks fine, but the documentation needs to be updated, and I'd really like to see some tests of offset and bearingTo at the poles before I sign off on the merge.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Krzysztof Findeisen
                Watchers:
                Krzysztof Findeisen, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel