Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12924

SpherePoint.offset should work at the poles and for negative offsets

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      AP S18-2
    • Team:
      Alert Production

      Description

      In replacing Coord with SpherePoint (DM-11162) I discovered a problem in the skymap package: skymap makes heavy use of Coord.offset, including for points at a pole. However, SpherePoint rejects such offsets (as well as negative offsets).

      I believe the behavior of offset for a coord at the pole is unambiguous and unsurprising if the coord is constructed from longitude, latitude. However, I acknowledge that this is less so for a coord constructed from a 3-vector. Nonetheless, I propose to change the behavior of SpherePoint to match Coord and document the behavior at the pole.

      I also propose to allow negative offsets, as the intent is unambiguous for those and Coord supports it.

      Also make sure the sign convention for the orientation of offset is the same for SpherePoint as Coord and document it carefully.

        Attachments

          Issue Links

            Activity

            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Link This issue relates to DM-11162 [ DM-11162 ]
            rowen Russell Owen made changes -
            Description In replacing Coord with SpherePoint (DM-11162) I discovered a problem in the skymap package: skymap makes heavy use of Coord.offset, including for points at a pole. However, SpherePoint rejects such offsets (as well as negative offsets).

            I believe the behavior of {{offset}} for a coord at the pole is unambiguous and unsurprising if the coord is constructed from longitude, latitude. However, I acknowledge that this is less so for a coord constructed from a 3-vector. Nonetheless, I propose to change the behavior of SpherePoint to match Coord and document the behavior at the pole.

            I also propose to allow negative offsets, as the intent is unambiguous for those and Coord supports it.
            In replacing Coord with SpherePoint (DM-11162) I discovered a problem in the skymap package: skymap makes heavy use of Coord.offset, including for points at a pole. However, SpherePoint rejects such offsets (as well as negative offsets).

            I believe the behavior of {{offset}} for a coord at the pole is unambiguous and unsurprising if the coord is constructed from longitude, latitude. However, I acknowledge that this is less so for a coord constructed from a 3-vector. Nonetheless, I propose to change the behavior of SpherePoint to match Coord and document the behavior at the pole.

            I also propose to allow negative offsets, as the intent is unambiguous for those and Coord supports it.

            Also make sure the sign convention for the orientation of offset is the same for {{SpherePoint}} as {{Coord}} and document it carefully.
            rowen Russell Owen made changes -
            Link This issue blocks DM-11162 [ DM-11162 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-11162 [ DM-11162 ]
            rowen Russell Owen made changes -
            Team Alert Production [ 10300 ]
            rowen Russell Owen made changes -
            Sprint AP S18-2 [ 677 ]
            rowen Russell Owen made changes -
            Rank Ranked higher
            rowen Russell Owen made changes -
            Story Points 0.5
            rowen Russell Owen made changes -
            Reviewers Krzysztof Findeisen [ krzys ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            krzys Krzysztof Findeisen made changes -
            Status In Review [ 10004 ] In Progress [ 3 ]
            krzys Krzysztof Findeisen made changes -
            Status In Progress [ 3 ] Reviewed [ 10101 ]
            rowen Russell Owen made changes -
            Story Points 0.5 1
            swinbank John Swinbank made changes -
            Epic Link DM-9679 [ 30784 ]
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Krzysztof Findeisen
                Watchers:
                Krzysztof Findeisen, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel