Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: obs_subaru, pipe_drivers
-
Labels:
-
Team:External
Description
HSC has had some features in the y-band images due to encoders in the instrument. Sogo Mineo has written some code to remove them (report and link to the code here), and we would like to include it in the pipeline.
Attachments
Issue Links
Activity
Thanks for volunteering to review, Jim Bosch!
Paul Price
added a comment - Thanks for volunteering to review, Jim Bosch ! Looks good overall. Comments on the PRs.
Left: visit=12979 with the correction. Right: the same exposure without the correction.
Note that the correction makes ccd=33 unusable (the CCD failed by the time the correction data was collected, so we mask it as BAD) and introduces a bad amplifier on ccd=43 (for a similar reason).
Paul Price
added a comment -
Left : visit=12979 with the correction. Right : the same exposure without the correction.
Note that the correction makes ccd=33 unusable (the CCD failed by the time the correction data was collected, so we mask it as BAD ) and introduces a bad amplifier on ccd=43 (for a similar reason). python/lsst/obs/subaru/strayLight/yStrayLight.py:
if detId in badAmps:
|
isBad = numpy.zeros_like(model, dtype=bool)
|
for ii in badAmps[detId]:
|
amp = exposure.getDetector()[ii]
|
box = amp.getBBox()
|
isBad[box.getMinY():box.getMaxY(), box.getMinX():box.getMaxX()] = True
|
box.getMinY():box.getMaxY() should be box.getStartY():box.getEndY()
because getEndY() returns the one-past-the-end value that is expected by
python slices. So too with X.
I think the other things are OK.
Sogo Mineo
added a comment - python/lsst/obs/subaru/strayLight/yStrayLight.py:
if detId in badAmps:
isBad = numpy.zeros_like(model, dtype=bool)
for ii in badAmps[detId]:
amp = exposure.getDetector()[ii]
box = amp.getBBox()
isBad[box.getMinY():box.getMaxY(), box.getMinX():box.getMaxX()] = True
box.getMinY():box.getMaxY() should be box.getStartY():box.getEndY()
because getEndY() returns the one-past-the-end value that is expected by
python slices. So too with X.
I think the other things are OK. Thanks, I didn't know about those! (But it is getBeginY instead of getStartY.) Fixed the code, and testing before merging.
Paul Price
added a comment - Thanks, I didn't know about those! (But it is getBeginY instead of getStartY .) Fixed the code, and testing before merging. Hey, that saves ccd=33! Thanks Sogo Mineo!
Merged to master.
Paul Price
added a comment - Hey, that saves ccd=33 ! Thanks Sogo Mineo !
Merged to master. Paul Price
added a comment - Post on CLO: https://community.lsst.org/t/y-band-stray-light-correction-for-hsc/2517 
price@pap-laptop:~/LSST/obs_subaru (tickets/DM-12979=) $ git subcommit 689fea06b5e8b492e798fcdfc67de1dd2bde4547 (HEAD -> tickets/DM-12979, origin/tickets/DM-12979)Author: Paul Price <price@astro.princeton.edu>Date: Tue Dec 12 13:55:12 2017 -0500add y-band stray light removalLEDs in an encoder in HSC are producing stray light on the detectors,producing the 'Eye of Y-band' feature. It can be removed bysubtracting open-shutter darks. However, because the pattern of straylight varies with rotator angle, many dark exposures are required.To reduce the data volume for the darks, the images have beencompressed using wavelets.The code here (provided by Sogo Mineo of NAOJ and only cleaned upa bit) retrieves the appropriate dark, uncompresses it and uses itto remove the stray light from an exposure.Some code here (provided by Satoshi Kawanomoto) may not meet codingstandards, but we are accepting it as legacy code. Unfortunately, notests are available for this code yet.policy/HscMapper.yaml | 3 +python/lsst/obs/subaru/isr.py | 13 +python/lsst/obs/subaru/strayLight/__init__.py | 2 +python/lsst/obs/subaru/strayLight/rotatorAngle.py | 268 +++++++++++++.../obs/subaru/strayLight/waveletCompression.py | 427 +++++++++++++++++++++python/lsst/obs/subaru/strayLight/yStrayLight.py | 220 +++++++++++6 files changed, 933 insertions(+)price@pap-laptop:~/LSST/pipe_drivers (tickets/DM-12979=) $ git subcommit 388cf09cfb4c36866cb6754651e0587d9790b1e2 (HEAD -> tickets/DM-12979, origin/tickets/DM-12979)Author: Paul Price <price@astro.princeton.edu>Date: Wed Dec 13 10:34:39 2017 -0500add visualizeVisitThis provides a facility to produce a binned image of the entire focalplane (butler product visit_camera).bin.src/visualizeVisit.py | 3 +python/lsst/pipe/drivers/skyCorrection.py | 43 +-------python/lsst/pipe/drivers/visualizeVisit.py | 160 +++++++++++++++++++++++++++++3 files changed, 167 insertions(+), 39 deletions(-)