Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12980

Add display_firefly to lsst_distrib

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: lsst_distrib, SUIT
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      SUIT Sprint 2017-12
    • Team:
      Science User Interface

      Description

      This ticket implements RFC-421.

      display_firefly will be added as setupRequired to the table file in lsst_distrib.

        Attachments

          Issue Links

            Activity

            Hide
            shupe David Shupe added a comment -

            This should be a quick review as it is a one-line change.

            I added the package at the end of ups/lsst_distrib.table. I don't know if some other ordering is used.

            Show
            shupe David Shupe added a comment - This should be a quick review as it is a one-line change. I added the package at the end of ups/lsst_distrib.table. I don't know if some other ordering is used.
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            Why does this package need to be setupOptional optional?

            Show
            jhoblitt Joshua Hoblitt added a comment - Why does this package need to be setupOptional optional?
            Hide
            shupe David Shupe added a comment -

            It should be setupRequired. I misunderstood the purpose of setupOptional.

            Show
            shupe David Shupe added a comment - It should be setupRequired . I misunderstood the purpose of setupOptional .
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            The PR looks good after being adjusted to use setupRequired.

            Show
            jhoblitt Joshua Hoblitt added a comment - The PR looks good after being adjusted to use setupRequired .
            Hide
            shupe David Shupe added a comment -

            Review approved on Github pull request.

            Show
            shupe David Shupe added a comment - Review approved on Github pull request.
            Hide
            shupe David Shupe added a comment -

            Merged

            Show
            shupe David Shupe added a comment - Merged

              People

              • Assignee:
                shupe David Shupe
                Reporter:
                shupe David Shupe
                Reviewers:
                Joshua Hoblitt
                Watchers:
                David Shupe, Joshua Hoblitt, Xiuqin Wu [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel