Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12980

Add display_firefly to lsst_distrib

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • lsst_distrib, SUIT
    • None
    • 1
    • SUIT Sprint 2017-12
    • Science User Interface

    Description

      This ticket implements RFC-421.

      display_firefly will be added as setupRequired to the table file in lsst_distrib.

      Attachments

        Issue Links

          Activity

            shupe David Shupe added a comment -

            This should be a quick review as it is a one-line change.

            I added the package at the end of ups/lsst_distrib.table. I don't know if some other ordering is used.

            shupe David Shupe added a comment - This should be a quick review as it is a one-line change. I added the package at the end of ups/lsst_distrib.table. I don't know if some other ordering is used.

            Why does this package need to be setupOptional optional?

            jhoblitt Joshua Hoblitt added a comment - Why does this package need to be setupOptional optional?
            shupe David Shupe added a comment -

            It should be setupRequired. I misunderstood the purpose of setupOptional.

            shupe David Shupe added a comment - It should be setupRequired . I misunderstood the purpose of setupOptional .

            The PR looks good after being adjusted to use setupRequired.

            jhoblitt Joshua Hoblitt added a comment - The PR looks good after being adjusted to use setupRequired .
            shupe David Shupe added a comment -

            Review approved on Github pull request.

            shupe David Shupe added a comment - Review approved on Github pull request.
            shupe David Shupe added a comment -

            Merged

            shupe David Shupe added a comment - Merged

            People

              shupe David Shupe
              shupe David Shupe
              Joshua Hoblitt
              David Shupe, Joshua Hoblitt, Xiuqin Wu [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.