Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12980

Add display_firefly to lsst_distrib

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: lsst_distrib, SUIT
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      SUIT Sprint 2017-12
    • Team:
      Science User Interface

      Description

      This ticket implements RFC-421.

      display_firefly will be added as setupRequired to the table file in lsst_distrib.

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-421 Add display_firefly to lsst_distrib

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            shupe David Shupe created issue -
            shupe David Shupe made changes -
            Field Original Value New Value
            Link This issue is triggered by RFC-421 [ RFC-421 ]
            shupe David Shupe made changes -
            Description This ticket implements RFC-421.

            {display_firefly} will be added as {setupOptional} to the table file in {lsst_distrib}.             		This ticket implements RFC-421.

            {{display_firefly}} will be added as {{setupOptional}} to the table file in {{lsst_distrib}}.
            Hide
            Permalink
            shupe David Shupe added a comment -

            This should be a quick review as it is a one-line change.

            I added the package at the end of ups/lsst_distrib.table. I don't know if some other ordering is used.

            Show
            shupe David Shupe added a comment - This should be a quick review as it is a one-line change. I added the package at the end of ups/lsst_distrib.table. I don't know if some other ordering is used.
            shupe David Shupe made changes -
            Reviewers Joshua Hoblitt [ jhoblitt ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Epic Link DM-8770 [ 28609 ]
            Hide
            Permalink
            jhoblitt Joshua Hoblitt added a comment -

            Why does this package need to be setupOptional optional?

            Show
            jhoblitt Joshua Hoblitt added a comment - Why does this package need to be setupOptional optional?
            shupe David Shupe made changes -
            Description This ticket implements RFC-421.

            {{display_firefly}} will be added as {{setupOptional}} to the table file in {{lsst_distrib}}.             		This ticket implements RFC-421.

            {{display_firefly}} will be added as {{setupRequired}} to the table file in {{lsst_distrib}}.
            Hide
            Permalink
            shupe David Shupe added a comment -

            It should be setupRequired. I misunderstood the purpose of setupOptional.

            Show
            shupe David Shupe added a comment - It should be setupRequired . I misunderstood the purpose of setupOptional .
            Hide
            Permalink
            jhoblitt Joshua Hoblitt added a comment -

            The PR looks good after being adjusted to use setupRequired.

            Show
            jhoblitt Joshua Hoblitt added a comment - The PR looks good after being adjusted to use setupRequired .
            jhoblitt Joshua Hoblitt made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            Permalink
            shupe David Shupe added a comment -

            Review approved on Github pull request.

            Show
            shupe David Shupe added a comment - Review approved on Github pull request.
            shupe David Shupe made changes -
            Status Reviewed [ 10101 ] Reviewed [ 10101 ]
            Hide
            Permalink
            shupe David Shupe added a comment -

            Merged

            Show
            shupe David Shupe added a comment - Merged
            shupe David Shupe made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              shupe David Shupe
              Reporter:
              shupe David Shupe
              Reviewers:
              Joshua Hoblitt
              Watchers:
              David Shupe, Joshua Hoblitt, Xiuqin Wu [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.