Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ip_isr, obs_decam, obs_subaru, pipe_tasks
-
Labels:
-
Story Points:4
-
Team:External
Description
I discovered some "fascinating" masking/interpolation failures around bleed trails when debugging the differences caused by DM-12968. More to follow.
Attachments
Issue Links
- blocks
-
DM-12968 Include INTERP+CR pixels in coadds
- Done
Activity
Minor changes made in pipe_tasks and obs_decam to adapt to the changes in ip_isr. Jenkins run (including ci_hsc) successful.
Great! Comments are on the GitHub PRs. I think using a context manager for applying and removing the flat/dark would help make the code path simpler.
Paul Price
added a comment - Great! Comments are on the GitHub PRs. I think using a context manager for applying and removing the flat/dark would help make the code path simpler. I believe I've addressed all comments. Just waiting on a final Jenkins run before merging.
Paul Price, could you review?
This does not include the option we discussed on Slack for using a CCD-wide average gain for brighter-fatter instead of the quoted gains; after looking at the code, that seemed to belong on a different ticket.
I have made changes to both ip_isr and obs_subaru (PRs will be created shortly). I have a Jenkins run in progress, and will look for other custom IsrTasks in other obs_* packages that also need to be updated - if you happen to know of any, please let me know.