Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-12985

Bad masking and interpolation around bleeds

    Details

    • Story Points:
      4
    • Team:
      External

      Description

      I discovered some "fascinating" masking/interpolation failures around bleed trails when debugging the differences caused by DM-12968. More to follow.

        Attachments

        1. sat-mask-fixed.png
          sat-mask-fixed.png
          249 kB
        2. sat-masks-1.png
          sat-masks-1.png
          30 kB
        3. sat-masks-2.png
          sat-masks-2.png
          37 kB
        4. sat-masks-3_calexp.png
          sat-masks-3_calexp.png
          246 kB
        5. sat-masks-3_postIsr.png
          sat-masks-3_postIsr.png
          172 kB
        6. sat-masks-3_raw.png
          sat-masks-3_raw.png
          133 kB

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Paul Price, could you review?

            This does not include the option we discussed on Slack for using a CCD-wide average gain for brighter-fatter instead of the quoted gains; after looking at the code, that seemed to belong on a different ticket.

            I have made changes to both ip_isr and obs_subaru (PRs will be created shortly). I have a Jenkins run in progress, and will look for other custom IsrTasks in other obs_* packages that also need to be updated - if you happen to know of any, please let me know.

            Show
            jbosch Jim Bosch added a comment - Paul Price , could you review? This does not include the option we discussed on Slack for using a CCD-wide average gain for brighter-fatter instead of the quoted gains; after looking at the code, that seemed to belong on a different ticket. I have made changes to both ip_isr and obs_subaru (PRs will be created shortly). I have a Jenkins run in progress, and will look for other custom IsrTasks in other obs_* packages that also need to be updated - if you happen to know of any, please let me know.
            Hide
            jbosch Jim Bosch added a comment -

            Minor changes made in pipe_tasks and obs_decam to adapt to the changes in ip_isr. Jenkins run (including ci_hsc) successful.

            Show
            jbosch Jim Bosch added a comment - Minor changes made in pipe_tasks and obs_decam to adapt to the changes in ip_isr. Jenkins run (including ci_hsc) successful.
            Hide
            price Paul Price added a comment -

            Great! Comments are on the GitHub PRs. I think using a context manager for applying and removing the flat/dark would help make the code path simpler.

            Show
            price Paul Price added a comment - Great! Comments are on the GitHub PRs. I think using a context manager for applying and removing the flat/dark would help make the code path simpler.
            Hide
            jbosch Jim Bosch added a comment -

            I believe I've addressed all comments. Just waiting on a final Jenkins run before merging.

            Show
            jbosch Jim Bosch added a comment - I believe I've addressed all comments. Just waiting on a final Jenkins run before merging.
            Hide
            jbosch Jim Bosch added a comment -

            Merged to master.

            Show
            jbosch Jim Bosch added a comment - Merged to master.

              People

              • Assignee:
                jbosch Jim Bosch
                Reporter:
                jbosch Jim Bosch
                Reviewers:
                Paul Price
                Watchers:
                Jim Bosch, Merlin Fisher-Levine, Paul Price, Robert Lupton, Yusra AlSayyad
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel