Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13062

meas_mosaic fails to build with w_2017_50

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Team:
      External

      Description

      the last part of errors

      g++ -o src/matches.os -c -std=c++14 -g -DLSST_LITTLE_ENDIAN=1 -O3 -Wall -Wno-unknown-pragmas -Wno-unused-local-typedefs -fno-lto -fPIC -Iinclude -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/astshim/14.0-10-ga7aaa25+4/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/ndarray/1.3.0-4-g0cefb59+4/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/pex_config/14.0-2-g319577b+6/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/daf_persistence/14.0-14-g87d16e8+5/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/pex_policy/14.0-1-g4b114ac+9/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/log/14.0-2-ga5af9b6+6/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/daf_base/14.0-4-ge2d7f21+6/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/utils/14.0-6-g4f52afe+5/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/pex_exceptions/14.0-1-g13ef843+8/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/base/14.0-8-g7f6dd6b+5/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/pybind11/2.1.1/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/starlink_ast/lsst-dev-g8bde9091e6/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/wcslib/5.13.lsst1+2/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/cfitsio/3360.lsst5/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/minuit2/5.34.14/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/fftw/3.3.4.lsst2/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/eigen/3.2.5.lsst3/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/mariadbclient/10.1.21.lsst2/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/log4cxx/0.10.0.lsst7/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/gsl/2.4/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/boost/1.60.lsst1+2/include -isystem /ssd/lsstsw/stack3_20171021/python/miniconda3-4.3.21/include/python3.6m -isystem /ssd/lsstsw/stack3_20171021/python/miniconda3-4.3.21/lib/python3.6/site-packages/numpy/core/include src/matches.cc
      g++ -o src/mosaicfit.os -c -std=c++14 -g -DLSST_LITTLE_ENDIAN=1 -O3 -Wall -Wno-unknown-pragmas -Wno-unused-local-typedefs -fno-lto -fPIC -Iinclude -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/astshim/14.0-10-ga7aaa25+4/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/ndarray/1.3.0-4-g0cefb59+4/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/pex_config/14.0-2-g319577b+6/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/daf_persistence/14.0-14-g87d16e8+5/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/pex_policy/14.0-1-g4b114ac+9/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/log/14.0-2-ga5af9b6+6/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/daf_base/14.0-4-ge2d7f21+6/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/utils/14.0-6-g4f52afe+5/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/pex_exceptions/14.0-1-g13ef843+8/include -I/ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/base/14.0-8-g7f6dd6b+5/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/pybind11/2.1.1/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/starlink_ast/lsst-dev-g8bde9091e6/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/wcslib/5.13.lsst1+2/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/cfitsio/3360.lsst5/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/minuit2/5.34.14/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/fftw/3.3.4.lsst2/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/eigen/3.2.5.lsst3/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/mariadbclient/10.1.21.lsst2/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/log4cxx/0.10.0.lsst7/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/gsl/2.4/include -isystem /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/boost/1.60.lsst1+2/include -isystem /ssd/lsstsw/stack3_20171021/python/miniconda3-4.3.21/include/python3.6m -isystem /ssd/lsstsw/stack3_20171021/python/miniconda3-4.3.21/lib/python3.6/site-packages/numpy/core/include src/mosaicfit.cc
      src/mosaicfit.cc: In function 'ndarray::Array<double, 1> lsst::meas::mosaic::calculateJacobian(const lsst::afw::image::Wcs&, const ndarray::Array<const double, 1>&, const ndarray::Array<const double, 1>&)':
      src/mosaicfit.cc:3219:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
           if (y.getShape()[0] != num) {
                                
      In file included from /opt/rh/devtoolset-6/root/usr/include/c++/6.3.1/x86_64-redhat-linux/bits/c++allocator.h:33:0,
                       from /opt/rh/devtoolset-6/root/usr/include/c++/6.3.1/bits/allocator.h:46,
                       from /opt/rh/devtoolset-6/root/usr/include/c++/6.3.1/memory:63,
                       from src/mosaicfit.cc:4:
      /opt/rh/devtoolset-6/root/usr/include/c++/6.3.1/ext/new_allocator.h: In instantiation of 'void __gnu_cxx::new_allocator<_Tp>::construct(_Up*, _Args&& ...) [with _Up = lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint>; _Args = {std::shared_ptr<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >}; _Tp = lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint>]':
      /opt/rh/devtoolset-6/root/usr/include/c++/6.3.1/bits/alloc_traits.h:475:4:   required from 'static void std::allocator_traits<std::allocator<_Tp1> >::construct(std::allocator_traits<std::allocator<_Tp1> >::allocator_type&, _Up*, _Args&& ...) [with _Up = lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint>; _Args = {std::shared_ptr<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >}; _Tp = lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint>; std::allocator_traits<std::allocator<_Tp1> >::allocator_type = std::allocator<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >]'
      /opt/rh/devtoolset-6/root/usr/include/c++/6.3.1/bits/shared_ptr_base.h:520:39:   required from 'std::_Sp_counted_ptr_inplace<_Tp, _Alloc, _Lp>::_Sp_counted_ptr_inplace(_Alloc, _Args&& ...) [with _Args = {std::shared_ptr<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >}; _Tp = lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint>; _Alloc = std::allocator<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >; __gnu_cxx::_Lock_policy _Lp = (__gnu_cxx::_Lock_policy)2u]'
      /opt/rh/devtoolset-6/root/usr/include/c++/6.3.1/bits/shared_ptr_base.h:615:4:   required from 'std::__shared_count<_Lp>::__shared_count(std::_Sp_make_shared_tag, _Tp*, const _Alloc&, _Args&& ...) [with _Tp = lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint>; _Alloc = std::allocator<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >; _Args = {std::shared_ptr<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >}; __gnu_cxx::_Lock_policy _Lp = (__gnu_cxx::_Lock_policy)2u]'
      /opt/rh/devtoolset-6/root/usr/include/c++/6.3.1/bits/shared_ptr_base.h:1100:35:   required from 'std::__shared_ptr<_Tp, _Lp>::__shared_ptr(std::_Sp_make_shared_tag, const _Alloc&, _Args&& ...) [with _Alloc = std::allocator<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >; _Args = {std::shared_ptr<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >}; _Tp = lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint>; __gnu_cxx::_Lock_policy _Lp = (__gnu_cxx::_Lock_policy)2u]'
      /opt/rh/devtoolset-6/root/usr/include/c++/6.3.1/bits/shared_ptr.h:319:64:   required from 'std::shared_ptr<_Tp>::shared_ptr(std::_Sp_make_shared_tag, const _Alloc&, _Args&& ...) [with _Alloc = std::allocator<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >; _Args = {std::shared_ptr<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >}; _Tp = lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint>]'
      /opt/rh/devtoolset-6/root/usr/include/c++/6.3.1/bits/shared_ptr.h:619:14:   required from 'std::shared_ptr<_Tp1> std::allocate_shared(const _Alloc&, _Args&& ...) [with _Tp = lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint>; _Alloc = std::allocator<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >; _Args = {std::shared_ptr<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >}]'
      /opt/rh/devtoolset-6/root/usr/include/c++/6.3.1/bits/shared_ptr.h:635:39:   required from 'std::shared_ptr<_Tp1> std::make_shared(_Args&& ...) [with _Tp = lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint>; _Args = {std::shared_ptr<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >}]'
      src/mosaicfit.cc:2505:75:   required from here
      /opt/rh/devtoolset-6/root/usr/include/c++/6.3.1/ext/new_allocator.h:120:4: error: no matching function for call to 'lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint>::Transform(std::shared_ptr<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >)'
        { ::new((void *)__p) _Up(std::forward<_Args>(__args)...); }
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      In file included from /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/geom/polygon/Polygon.h:38:0,
                       from /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/geom.h:45,
                       from /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/table/FieldBase.h:15,
                       from /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/table/Key.h:5,
                       from /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/table/Schema.h:10,
                       from /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/table/BaseRecord.h:7,
                       from /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/table/Match.h:32,
                       from src/mosaicfit.cc:12:
      /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/geom/Transform.h:272:14: note: candidate: lsst::afw::geom::Transform<FromEndpoint, ToEndpoint>::Transform(std::shared_ptr<ast::FrameSet>) [with FromEndpoint = lsst::afw::geom::Point2Endpoint; ToEndpoint = lsst::afw::geom::Point2Endpoint]
           explicit Transform(std::shared_ptr<ast::FrameSet> frameSet);
                    ^~~~~~~~~
      /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/geom/Transform.h:272:14: note:   no known conversion for argument 1 from 'std::shared_ptr<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >' to 'std::shared_ptr<ast::FrameSet>'
      /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/geom/Transform.h:113:14: note: candidate: lsst::afw::geom::Transform<FromEndpoint, ToEndpoint>::Transform(const ast::FrameSet&, bool) [with FromEndpoint = lsst::afw::geom::Point2Endpoint; ToEndpoint = lsst::afw::geom::Point2Endpoint]
           explicit Transform(ast::FrameSet const &frameSet, bool simplify = true);
                    ^~~~~~~~~
      /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/geom/Transform.h:113:14: note:   no known conversion for argument 1 from 'std::shared_ptr<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >' to 'const ast::FrameSet&'
      /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/geom/Transform.h:91:14: note: candidate: lsst::afw::geom::Transform<FromEndpoint, ToEndpoint>::Transform(const ast::Mapping&, bool) [with FromEndpoint = lsst::afw::geom::Point2Endpoint; ToEndpoint = lsst::afw::geom::Point2Endpoint]
           explicit Transform(ast::Mapping const &mapping, bool simplify = true);
                    ^~~~~~~~~
      /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/geom/Transform.h:91:14: note:   no known conversion for argument 1 from 'std::shared_ptr<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >' to 'const ast::Mapping&'
      /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/geom/Transform.h:77:5: note: candidate: lsst::afw::geom::Transform<FromEndpoint, ToEndpoint>::Transform(lsst::afw::geom::Transform<FromEndpoint, ToEndpoint>&&) [with FromEndpoint = lsst::afw::geom::Point2Endpoint; ToEndpoint = lsst::afw::geom::Point2Endpoint]
           Transform(Transform &&) = default;
           ^~~~~~~~~
      /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/geom/Transform.h:77:5: note:   no known conversion for argument 1 from 'std::shared_ptr<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >' to 'lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint>&&'
      /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/geom/Transform.h:76:5: note: candidate: lsst::afw::geom::Transform<FromEndpoint, ToEndpoint>::Transform(const lsst::afw::geom::Transform<FromEndpoint, ToEndpoint>&) [with FromEndpoint = lsst::afw::geom::Point2Endpoint; ToEndpoint = lsst::afw::geom::Point2Endpoint]
           Transform(Transform const &) = default;
           ^~~~~~~~~
      /ssd/lsstsw/stack3_20171021/stack/miniconda3-4.3.21-10a4fa6/Linux64/afw/14.0-26-gaaaaa5c36/include/lsst/afw/geom/Transform.h:76:5: note:   no known conversion for argument 1 from 'std::shared_ptr<lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint> >' to 'const lsst::afw::geom::Transform<lsst::afw::geom::Point2Endpoint, lsst::afw::geom::Point2Endpoint>&'
      scons: *** [src/mosaicfit.os] Error 1
      scons: building terminated because of errors.
      

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            I also took the opportunity to fix a signed/unsigned comparison warning.

            pprice@lsst-dev01:~/LSST/meas/mosaic[tickets/DM-13062] $ git sub
            commit 90aef15884ad8e6761174011782e1daeded6d71f
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Mon Dec 18 10:33:33 2017 -0600
             
                mosaicfit: fix signed/unsigned comparison warning
                
                src/mosaicfit.cc: In function ‘ndarray::Array<double, 1> lsst::meas::mosaic::calculateJacobian(const lsst::afw::image::Wcs&, const ndarray::Array<const double, 1>&, const ndarray::Array<const double, 1>&)’:
                src/mosaicfit.cc:3219:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
                     if (y.getShape()[0] != num) {
             
             src/mosaicfit.cc | 2 +-
             1 file changed, 1 insertion(+), 1 deletion(-)
             
            commit a7b974938ca737ef350c6ab123c9dfaa3cc4f885
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Mon Dec 18 10:38:38 2017 -0600
             
                mosaicfit: adapt to API changes in afw::geom:Transform
                
                Now have to dereference in order to make a new Transform.
             
             src/mosaicfit.cc | 8 ++++----
             1 file changed, 4 insertions(+), 4 deletions(-)
            

            Show
            price Paul Price added a comment - I also took the opportunity to fix a signed/unsigned comparison warning. pprice@lsst-dev01:~/LSST/meas/mosaic[tickets/DM-13062] $ git sub commit 90aef15884ad8e6761174011782e1daeded6d71f Author: Paul Price <price@astro.princeton.edu> Date: Mon Dec 18 10:33:33 2017 -0600   mosaicfit: fix signed/unsigned comparison warning src/mosaicfit.cc: In function ‘ndarray::Array<double, 1> lsst::meas::mosaic::calculateJacobian(const lsst::afw::image::Wcs&, const ndarray::Array<const double, 1>&, const ndarray::Array<const double, 1>&)’: src/mosaicfit.cc:3219:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (y.getShape()[0] != num) {   src/mosaicfit.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   commit a7b974938ca737ef350c6ab123c9dfaa3cc4f885 Author: Paul Price <price@astro.princeton.edu> Date: Mon Dec 18 10:38:38 2017 -0600   mosaicfit: adapt to API changes in afw::geom:Transform Now have to dereference in order to make a new Transform.   src/mosaicfit.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            LGTM and it builds fine now. Thanks for the quick fix!

            Show
            hchiang2 Hsin-Fang Chiang added a comment - LGTM and it builds fine now. Thanks for the quick fix!
            Hide
            price Paul Price added a comment -

            Merged to master.

            Show
            price Paul Price added a comment - Merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                hchiang2 Hsin-Fang Chiang
                Reviewers:
                Hsin-Fang Chiang
                Watchers:
                Hsin-Fang Chiang, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: