Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13067

Add tests for functionality introduced to support y-band background subtraction

    XMLWordPrintable

Details

    • Story
    • Status: To Do
    • Resolution: Unresolved
    • None
    • obs_subaru
    • External

    Description

      DM-12979 introduced sogo.mineo's code to do subtraction of the "Eye of y-band" feature, which includes functions to calculate rotator angles and perform compression. To ease maintenance of these, it would be helpful to have unit tests of those functions.

      Attachments

        Issue Links

          Activity

            sogo.mineo Sogo Mineo added a comment - I pushed the branch to https://github.com/SogoMineo/obs_subaru/tree/tickets/DM-13067
            tjenness Tim Jenness added a comment -

            price what do you want to do about this? I tried to run the test and one of the tests fails because it is thinking that a property set should be a visitInfo. I also am somewhat concerned by all the code in rotatorAngle.py that should not exist because it should be using standard astrometry libraries.

            tjenness Tim Jenness added a comment - price what do you want to do about this? I tried to run the test and one of the tests fails because it is thinking that a property set should be a visitInfo. I also am somewhat concerned by all the code in rotatorAngle.py that should not exist because it should be using standard astrometry libraries.
            price Paul Price added a comment -

            It seems to me that at least some, if not all, of this functionality is wanted, even if it's not in an ideal state. But I believe czw is our ISR Guy, and he may have an opinion that we should hear.

            price Paul Price added a comment - It seems to me that at least some, if not all, of this functionality is wanted, even if it's not in an ideal state. But I believe czw is our ISR Guy, and he may have an opinion that we should hear.

            I feel like I missed some discussion (unless this is just a check on very old open tickets). 

            If it's easy to fix that test (and rebase the 700+ commits that branch is behind) then I would be in favor of doing so.  However, it's clear that this isn't a high priority for anyone, as this tests code that we've long accepted "just work."

            czw Christopher Waters added a comment - I feel like I missed some discussion (unless this is just a check on very old open tickets).  If it's easy to fix that test (and rebase the 700+ commits that branch is behind) then I would be in favor of doing so.  However, it's clear that this isn't a high priority for anyone, as this tests code that we've long accepted "just work."
            tjenness Tim Jenness added a comment -

            It came up as an old ticket and then I tried the code to see what happened.

            tjenness Tim Jenness added a comment - It came up as an old ticket and then I tried the code to see what happened.

            People

              sogo.mineo Sogo Mineo
              price Paul Price
              Christopher Waters, Paul Price, Sogo Mineo, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:

                Jenkins

                  No builds found.