I made a branch named tickets/DM-13067 in my local repository and added a test code in it. How can I make a pull request?

Please push your branch to your personal fork on GitHub, and then we can create a pull request.

I tried to push my branch but permission was denied:

fatal: unable to access 'https://github.com/lsst/obs_subaru.git/': The requested URL returned error: 403

My github account is SogoMineo and its primary email address is of NAOJ. Do I have permission to push branches?

I don't think you have permission to push to the LSST account, but you should be able to push to your own GitHub account, from which we can issue a pull request.

I pushed the branch to https://github.com/SogoMineo/obs_subaru/tree/tickets/DM-13067

Paul Price what do you want to do about this? I tried to run the test and one of the tests fails because it is thinking that a property set should be a visitInfo. I also am somewhat concerned by all the code in rotatorAngle.py that should not exist because it should be using standard astrometry libraries.

It seems to me that at least some, if not all, of this functionality is wanted, even if it's not in an ideal state. But I believe Christopher Waters is our ISR Guy, and he may have an opinion that we should hear.

I feel like I missed some discussion (unless this is just a check on very old open tickets). 

If it's easy to fix that test (and rebase the 700+ commits that branch is behind) then I would be in favor of doing so.  However, it's clear that this isn't a high priority for anyone, as this tests code that we've long accepted "just work."

It came up as an old ticket and then I tried the code to see what happened.