Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13069

lander failures should cause Travis build to fail

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      When Lander fails to upload a PDF at the end of a build, the build is still marked as a success (see, e.g., https://travis-ci.org/lsst/LDM-534/builds/318277471). That's confusing — please can we change this so the failure is acknowledged?

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          jsick Jonathan Sick added a comment -

          We could certainly do it that way. The current arrangement was intentional so that breakages in the landing page system could be handled out of band with document PRs (so that documentation merges weren't blocked on the landing page system). But I'm happy to change it since landing page breakages are going unnoticed and unreported and that's not good either.

          Show
          jsick Jonathan Sick added a comment - We could certainly do it that way. The current arrangement was intentional so that breakages in the landing page system could be handled out of band with document PRs (so that documentation merges weren't blocked on the landing page system). But I'm happy to change it since landing page breakages are going unnoticed and unreported and that's not good either.
          Hide
          Permalink
          jsick Jonathan Sick added a comment -

          Updated Travis config in these documents:

          Show
          jsick Jonathan Sick added a comment - Updated Travis config in these documents: [x] dmtr-51 https://github.com/lsst-dm/DMTR-51 [x] dmtr-53 https://github.com/lsst-dm/DMTR-53 [x] ldm-135 https://github.com/lsst/LDM-135 [x] ldm-148 https://github.com/lsst/LDM-148 [x] ldm-151 https://github.com/lsst/LDM-151 [x] ldm-152 https://github.com/lsst/LDM-152 [x] ldm-230 https://github.com/lsst/LDM-230 [x] ldm-472 https://github.com/lsst/LDM-472 [x] ldm-503 https://github.com/lsst/LDM-503 [x] ldm-533 https://github.com/lsst/LDM-533 [x] ldm-534 https://github.com/lsst/LDM-534 [x] ldm-542 https://github.com/lsst/LDM-542 [x] ldm-556 https://github.com/lsst/LDM-556 [x] ldm-562 https://github.com/lsst/LDM-562 [x] ldm-572 https://github.com/lsst/LDM-572 [x] ldm-592 https://github.com/lsst/LDM-592 [x] lpm-231 https://github.com/lsst/LPM-231 [x] lse-163 https://github.com/lsst/LSE-163 [x] lse-349 https://github.com/lsst/LSE-349 [x] lse-61 https://github.com/lsst/LSE-61
          Hide
          Permalink
          jsick Jonathan Sick added a comment -

          More:

          Show
          jsick Jonathan Sick added a comment - More: [x] dmtn-017 https://github.com/lsst-dm/dmtn-017 [x] dmtn-020 https://github.com/lsst-dm/dmtn-020.git [x] dmtn-036 https://github.com/lsst-dm/dmtn-036.git [x] dmtn-044 https://github.com/lsst-dm/dmtn-044.git [x] dmtn-049 https://github.com/lsst-dm/dmtn-049.git [x] dmtn-051 https://github.com/lsst-dm/dmtn-051.git [x] dmtn-063 https://github.com/lsst-dm/dmtn-063 [x] dmtn-065 https://github.com/lsst-dm/dmtn-065.git [x] dmtn-069 https://github.com/lsst-dm/dmtn-069 [x] dmtn-070 https://github.com/lsst-dm/dmtn-070
          Hide
          Permalink
          jsick Jonathan Sick added a comment -

          Updated the document template's .travis.yml too.

          Show
          jsick Jonathan Sick added a comment - Updated the document template's .travis.yml too.

            People

            Assignee:
            jsick Jonathan Sick
            Reporter:
            swinbank John Swinbank
            Watchers:
            John Swinbank, Jonathan Sick
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.