Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13071

CovarianceMatrix*Key and Point*Key have inconsistent templating in pybind11

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      2

      Description

      afw.table.aggregates provides PointKey and CovarianceMatrixKey, the former of which has templated Point2DKey and Point2IKey versions, while the latter has CovarianceMatrix2fKey, CovarianceMatrix2dKey (and similar 3f, 4f, Xf, 3d, 4d, Xd). I'm not sure why CovarianceMatrix uses lowercase instead of the uppercase for Point (PointKey has the templated versions also defined in the aggregates header, but CovarianceMatrix does not), but we should make these consistent.

        Attachments

          Issue Links

          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            The history is that Point and PointKey follow the uppercase afw.image conventions, while Eigen and CovarianceMatrixKey follow the lowercase Eigen conventions. That's doesn't make the inconsistency okay, but it does mean it's bigger than it may appear here.

            Show
            jbosch Jim Bosch added a comment - The history is that Point and PointKey follow the uppercase afw.image conventions, while Eigen and CovarianceMatrixKey follow the lowercase Eigen conventions. That's doesn't make the inconsistency okay, but it does mean it's bigger than it may appear here.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Are we intending to do anything about this? Is it still relevant?

            Show
            tjenness Tim Jenness added a comment - Are we intending to do anything about this? Is it still relevant?
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            I'm just gonna Won't Fix this.  It's unfortunate, but I don't think the improvement is worth the API-change disruption fixing it would require.

            Show
            jbosch Jim Bosch added a comment - I'm just gonna Won't Fix this.  It's unfortunate, but I don't think the improvement is worth the API-change disruption fixing it would require.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Jim Bosch, John Parejko, John Swinbank, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.