I really love the density plotting in the plot-t9813-griCModel-wFit-fit.png-family plots! It'd be helpful on the "noFit" plots as well (not on this ticket).
Ok, I'll make a ticket.
Is the x-axis on the histogram on the right still "Distance to Polynomial fit (mmag)"?
Yes. I tried to make this clear by the color coding (green for the fit params in the left panel and a green histogram on the right). I could change these to use the Principle Color fits, but I opted not too as the fits printed for wPerp and wPara on these are "live" (per field). The fixed coeffs from averaging all 3 fields are those used in the plot-t9813-color_wPerp-psfMagHist.png plots (i.e. those are the "calibrated" ones that should be considered the authoritative numbers for the Principal Color analysis – I'm adding the coeffs used to those plots). The fits per field are useful in case we have funky behavior in a given tract (this will also be revealed in the "calibrated" plots as the offset and likely stdev also will be significant). I can change the histogram to plot the per-field wPerp fit if you think it would be more useful/less confusing.
It looks like you missed coaddAnalysis.py when incorporating Russell's python standards fixes on his ticket branch.
Ah, thanks! Will update.
Question: while I'm going through the pull request on github, would you like me to check to standards problems in the whole file as a way to get started on getting it ready for the stack or just the lines changed?
That's totally up to you. This needs to be done, but we could isolate it all to another ticket (which I will also create)
I'll ping you when the above mentioned changes are pushed.