# update expected results file in SDSS demo test

XMLWordPrintable

## Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
1
• Sprint:
Science Pipelines DM-W15-1
• Team:
Data Release Production

## Description

Update the expected outputs in the SDSS DM stack demo repo to match what we expect from the new meas_base framework.

## Activity

Hide
Perry Gee added a comment -

This is already checked in to master, as you know.

I checked in the files that are produced when the demo is run without any alterations to the config. I can't really test it, but it should produce the same results as buildBot.

I did test the sdss demo using the old pipeline and configuring it so that GaussianFlux has fixed=True. In this configuration, we match against the old pipeline to within .5%.

As noted in the DM-1071 ticket changes are expected because of the change to GaussianFlux, a sub-percentage change to PsfFlux, and because the EDGE condition throw is handled differently in the new framework. Otherwise, the two pipelines match.

Show
Perry Gee added a comment - This is already checked in to master, as you know. I checked in the files that are produced when the demo is run without any alterations to the config. I can't really test it, but it should produce the same results as buildBot. I did test the sdss demo using the old pipeline and configuring it so that GaussianFlux has fixed=True. In this configuration, we match against the old pipeline to within .5%. As noted in the DM-1071 ticket changes are expected because of the change to GaussianFlux, a sub-percentage change to PsfFlux, and because the EDGE condition throw is handled differently in the new framework. Otherwise, the two pipelines match.
Hide
Kian-Tat Lim added a comment -

The evaluation that was done on the results changes is sufficient.

Buildbot says:

 +++ Files "detected-sources_small.txt.expected" and "detected-sources_small.txt" are equal The simple integration demo was successfully run.

So the update was done correctly. Looks good to me.

Show
Kian-Tat Lim added a comment - The evaluation that was done on the results changes is sufficient. Buildbot says: +++ Files "detected-sources_small.txt.expected" and "detected-sources_small.txt" are equal The simple integration demo was successfully run. So the update was done correctly. Looks good to me.

## People

• Assignee:
Perry Gee
Reporter:
Jim Bosch
Reviewers:
Kian-Tat Lim
Watchers:
Jim Bosch, Kian-Tat Lim, Perry Gee