Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13180

Specifications without corresponding metric in verify_metrics

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Simon Krughoff when testing dispatch_verify.py with the Flask based SQuaSH RESTful API I noticed some specifications without the corresponding metric in verify_metrics

      For instance:

      {'metadata_query': {},
        'name': 'release.AD3.FY19',
        'tags': [],
        'threshold': {'operator': '<=', 'unit': 'marcsec', 'value': 30.0},
        'type': 'threshold'},
      

      When loading the specs to SQuaSH I get:

       
      {'message': 'Metric `release.AD3` not found. You must provide a valid name for the metric associated with this specification.'}
      

      I could ignore that to get the current metrics and specifications registered in SQuaSH, for example:

      https://github.com/lsst-sqre/squash-rest-api/blob/master/app/resources/specification.py#L234

      but we should enforce that specifications are consistent with metric definitions.

        Attachments

          Issue Links

            Activity

            Hide
            krughoff Simon Krughoff added a comment -

            OK thanks. I'll try to take a look this week.

            Show
            krughoff Simon Krughoff added a comment - OK thanks. I'll try to take a look this week.
            Hide
            krughoff Simon Krughoff added a comment -

            Angelo Fausti I have, I believe, corrected things. Will you have a look please?

            Show
            krughoff Simon Krughoff added a comment - Angelo Fausti I have, I believe, corrected things. Will you have a look please?
            Hide
            afausti Angelo Fausti added a comment - - edited

            Simon Krughoff I have run the notebook against the demo instance and also against a clean database, all metrics and specifications were successfully created.

            Once you merge this branch I'll update the metrics and specifications in the SQuaSH production instance.

            Show
            afausti Angelo Fausti added a comment - - edited Simon Krughoff I have run the notebook against the demo instance and also against a clean database, all metrics and specifications were successfully created. Once you merge this branch I'll update the metrics and specifications in the SQuaSH production instance.
            Hide
            krughoff Simon Krughoff added a comment -

            Merged, but as I say that, we need to keep an eye on validate_drp. I didn't go to the trouble of making a test run. I hope that doesn't bite us.

            Show
            krughoff Simon Krughoff added a comment - Merged, but as I say that, we need to keep an eye on validate_drp . I didn't go to the trouble of making a test run. I hope that doesn't bite us.
            Hide
            tjenness Tim Jenness added a comment -
            Show
            tjenness Tim Jenness added a comment - It's possible that validate_drp is now broken: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29565/pipeline

              People

              • Assignee:
                krughoff Simon Krughoff
                Reporter:
                afausti Angelo Fausti
                Reviewers:
                Angelo Fausti
                Watchers:
                Angelo Fausti, Jonathan Sick, Simon Krughoff, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel