Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13187

jointcal selected_*_refStars is not correctly computed

    XMLWordPrintable

Details

    Description

      Jointcal reports the collected_*_refStars and the selected_*_refStars, which should represent the total number of available refStars from the input refcat, and the number that were associated to fittedStars. The latter is the number that are important for the actual fit. Thanks to rowen's investigation about a separate issue, I realized that the selected_*_refStars metrics are incorrect: jointcal does not alter the associations.refStarList during selection, but rather the pointers between fittedStars and refStars.

       

      To fix this, we need to traverse the fittedStarList and count the number of fittedStars that have a non-nullptr refStar. Once done, we'll have to update all of the selected_*_refStars metrics.

      Fixing this will help debug the jointcal test failures in DM-10765.

      Attachments

        Issue Links

          Activity

            rowen, could you please review this? It's short, and should help us determine what's going wrong with your SkyWcs changes.

            Parejkoj John Parejko added a comment - rowen , could you please review this? It's short, and should help us determine what's going wrong with your SkyWcs changes.
            rowen Russell Owen added a comment -

            Looks good. One or two minor suggested changes and one or two questions on the pull request.

            rowen Russell Owen added a comment - Looks good. One or two minor suggested changes and one or two questions on the pull request.
            Parejkoj John Parejko added a comment -

            Thanks for the review. I fixed and replied to your concerns in the PR.

            Merged and done. Please rebase your jointcal working branch onto master and we'll dig into the refstar changes then.

            Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27268/pipeline/

            Parejkoj John Parejko added a comment - Thanks for the review. I fixed and replied to your concerns in the PR. Merged and done. Please rebase your jointcal working branch onto master and we'll dig into the refstar changes then. Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27268/pipeline/

            People

              Parejkoj John Parejko
              Parejkoj John Parejko
              Russell Owen
              John Parejko, John Swinbank, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.