# jointcal selected_*_refStars is not correctly computed

XMLWordPrintable

## Details

• Type: Bug
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
2
• Sprint:
AP S18-2
• Team:

## Description

Jointcal reports the collected_*_refStars and the selected_*_refStars, which should represent the total number of available refStars from the input refcat, and the number that were associated to fittedStars. The latter is the number that are important for the actual fit. Thanks to Russell Owen's investigation about a separate issue, I realized that the selected_*_refStars metrics are incorrect: jointcal does not alter the associations.refStarList during selection, but rather the pointers between fittedStars and refStars.

To fix this, we need to traverse the fittedStarList and count the number of fittedStars that have a non-nullptr refStar. Once done, we'll have to update all of the selected_*_refStars metrics.

Fixing this will help debug the jointcal test failures in DM-10765.

## Activity

John Parejko created issue -
Field Original Value New Value
Link This issue relates to DM-10765 [ DM-10765 ]
 Description Jointcal reports the {{collected_*_refStars}} and the {{selected_*_refStars}}, which should represent the total number of available refStars from the input refcat, and the number that were associated to fittedStars. The latter is the number that are important for the actual fit. Thanks to [~rowen]'s investigation about a separate issue, I realized that the {{selected_*_refStars}} metrics are incorrect: jointcal does not alter the {{associations.refStarList}} during selection, but rather the pointers between fittedStars and refStars.   To fix this, we need to traverse the fittedStarList and count the number of fittedStars that have a non-nullptr \{\{refStar}}. Once done, we'll have to update all of the {{selected_*_refStars}} metrics. Fixing this will help debug the jointcal test failures in DM-10765. Jointcal reports the collected_*_refStars and the {{selected_*_refStars}}, which should represent the total number of available refStars from the input refcat, and the number that were associated to fittedStars. The latter is the number that are important for the actual fit. Thanks to [~rowen]'s investigation about a separate issue, I realized that the {{selected_*_refStars}} metrics are incorrect: jointcal does not alter the {{associations.refStarList}} during selection, but rather the pointers between fittedStars and refStars.   To fix this, we need to traverse the fittedStarList and count the number of fittedStars that have a non-nullptr \{\{refStar}}. Once done, we'll have to update all of the {{selected_*_refStars}} metrics. Fixing this will help debug the jointcal test failures in DM-10765.
 Description Jointcal reports the collected_*_refStars and the {{selected_*_refStars}}, which should represent the total number of available refStars from the input refcat, and the number that were associated to fittedStars. The latter is the number that are important for the actual fit. Thanks to [~rowen]'s investigation about a separate issue, I realized that the {{selected_*_refStars}} metrics are incorrect: jointcal does not alter the {{associations.refStarList}} during selection, but rather the pointers between fittedStars and refStars.   To fix this, we need to traverse the fittedStarList and count the number of fittedStars that have a non-nullptr \{\{refStar}}. Once done, we'll have to update all of the {{selected_*_refStars}} metrics. Fixing this will help debug the jointcal test failures in DM-10765. Jointcal reports the {{collected\_\*\_refStars}} and the {{selected\_\*\_refStars}}, which should represent the total number of available refStars from the input refcat, and the number that were associated to fittedStars. The latter is the number that are important for the actual fit. Thanks to [~rowen]'s investigation about a separate issue, I realized that the {{selected_*_refStars}} metrics are incorrect: jointcal does not alter the {{associations.refStarList}} during selection, but rather the pointers between fittedStars and refStars.   To fix this, we need to traverse the fittedStarList and count the number of fittedStars that have a non-nullptr \{\{refStar}}. Once done, we'll have to update all of the {{selected_*_refStars}} metrics. Fixing this will help debug the jointcal test failures in DM-10765.
 Status To Do [ 10001 ] In Progress [ 3 ]
Hide
John Parejko added a comment -

Russell Owen, could you please review this? It's short, and should help us determine what's going wrong with your SkyWcs changes.

Show
John Parejko added a comment - Russell Owen , could you please review this? It's short, and should help us determine what's going wrong with your SkyWcs changes.
 Reviewers Russell Owen [ rowen ] Status In Progress [ 3 ] In Review [ 10004 ]
Hide
Russell Owen added a comment -

Looks good. One or two minor suggested changes and one or two questions on the pull request.

Show
Russell Owen added a comment - Looks good. One or two minor suggested changes and one or two questions on the pull request.
 Status In Review [ 10004 ] Reviewed [ 10101 ]
Hide
John Parejko added a comment -

Thanks for the review. I fixed and replied to your concerns in the PR.

Merged and done. Please rebase your jointcal working branch onto master and we'll dig into the refstar changes then.

Show
John Parejko added a comment - Thanks for the review. I fixed and replied to your concerns in the PR. Merged and done. Please rebase your jointcal working branch onto master and we'll dig into the refstar changes then. Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27268/pipeline/
 Resolution Done [ 10000 ] Status Reviewed [ 10101 ] Done [ 10002 ]
 Epic Link DM-11783 [ 34260 ]

## People

• Assignee:
John Parejko
Reporter:
John Parejko
Reviewers:
Russell Owen
Watchers:
John Parejko, John Swinbank, Russell Owen