Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13231

Make photoCalib outField write to _flux instead of _calFlux

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw

      Description

      DM-10729 implemented one way of writing back out to a catalog prior to RFC-322 being implemented, that introduced a _calFlux field for the outField. _calFlux isn't used elsewhere in the stack, and is inconsistent with the documentation.

      This ticket is to change it to write to outField+"_flux", which allows writing the calibrated fluxes back to the same field (by having inField==outField), which is consistent with what meas_mosaic is currently doing.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -
            Show
            Parejkoj John Parejko added a comment - Jim Bosch can you please look at this small change? Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27301/pipeline
            Hide
            jbosch Jim Bosch added a comment -

            Code looks fine, but you you please make sure meas_mosaic still passes its tests after this change?

            Show
            jbosch Jim Bosch added a comment - Code looks fine, but you you please make sure meas_mosaic still passes its tests after this change?
            Hide
            Parejkoj John Parejko added a comment -

            I only see two test files in meas_mosaic, and they both pass with my local build of afw with this change in place.

            Show
            Parejkoj John Parejko added a comment - I only see two test files in meas_mosaic, and they both pass with my local build of afw with this change in place.
            Hide
            Parejkoj John Parejko added a comment -

            Jenkins passed, meas_mosaic appears to be happy, and this lets me use pipe_analysis.visitAnalysis on jointcal and meas_mosaic output. Thanks for the quick review!

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Jenkins passed, meas_mosaic appears to be happy, and this lets me use pipe_analysis.visitAnalysis on jointcal and meas_mosaic output. Thanks for the quick review! Merged and done.

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Jim Bosch
                Watchers:
                Jim Bosch, John Parejko, John Swinbank, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel