Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13241

Client table filtering stopped working after changes filter syntax

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Firefly
    • Labels:

      Description

      '%' wildcard was added to filter syntax to allow for more advanced string filtering.  This was not implemented for client tables.  Make sure this feature is implemented for client table as well.  Look at src/firefly/js/tables/TableUtil.js:516 for entry point to the code.

      Also, since there were major changes to table backend support, please test to make sure other column types still work as expected.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          cwang Cindy Wang [X] (Inactive) added a comment - - edited

          While fixing the filtering issue for client table, more issues regarding the syntax of filter strings and the logic used to correct the filter string were found. 

          The table filter string syntax is assumed to be compliant to that of SQL 'where' clause. It will be validated and auto-corrected per the syntax of SQL where clause in case it is not a valid one. 

          Please refer to the attached file, 'Firefly_table_filter.docx',  to get more details about how to enter the filtering string  and how auto correction works in Firefly. 

           

           

          Show
          cwang Cindy Wang [X] (Inactive) added a comment - - edited While fixing the filtering issue for client table, more issues regarding the syntax of filter strings and the logic used to correct the filter string were found.  The table filter string syntax is assumed to be compliant to that of SQL 'where' clause. It will be validated and auto-corrected per the syntax of SQL where clause in case it is not a valid one.  Please refer to the attached file, 'Firefly_table_filter.docx',  to get more details about how to enter the filtering string  and how auto correction works in Firefly.     
          Hide
          Permalink
          gpdf Gregory Dubois-Felsmann added a comment -

          Thank you, Cindy Wang [X]. I'll have a look at this over the weekend.

           

          Show
          gpdf Gregory Dubois-Felsmann added a comment - Thank you, Cindy Wang [X] . I'll have a look at this over the weekend.  
          Hide
          Permalink
          cwang Cindy Wang [X] (Inactive) added a comment -

          The tooltip providing the hint for the usage of column filtering box needs some modification as those filtering issues are fixed. Currently the tooltip has the content like: 

          Valid values are one of (=, >, <, !=, >=, <=, LIKE, IS, IS NOT) followed by a value separated by a space.
          Or 'IN', followed by a list of values separated by commas.
          Examples:  > 12345; != 3000; IN a,b,c,d`

          Show
          cwang Cindy Wang [X] (Inactive) added a comment - The tooltip providing the hint for the usage of column filtering box needs some modification as those filtering issues are fixed. Currently the tooltip has the content like:  Valid values are one of (=, >, <, !=, >=, <=, LIKE, IS, IS NOT) followed by a value separated by a space. Or 'IN', followed by a list of values separated by commas. Examples:  > 12345; != 3000; IN a,b,c,d`

            People

            Assignee:
            cwang Cindy Wang [X] (Inactive)
            Reporter:
            loi Loi Ly
            Reviewers:
            Loi Ly
            Watchers:
            Cindy Wang [X] (Inactive), Gregory Dubois-Felsmann, Loi Ly, Trey Roby
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.