Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13269

Improve jointcal debugging output

    XMLWordPrintable

    Details

      Description

      The fitter chi2 contributions debug output files need to be cleaned up and improved so we can do direct comparisons of jointcal's internal model, pre- and post-fit. Also have to make some plots to test that the output is good.

        Attachments

          Issue Links

          is triggering

          Bug - A problem which impairs or prevents the functions of the product. DM-13571 fix plot_photoCalib bounds

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-11785 Run jointcal on acceptance data

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Krzysztof Findeisen can you please review the C++ changes in the first two commits here?

            Chris Morrison can you please review the jupyter notebooks? I'm not sure the best way to go about that, but you can view them inline in github with the View button.

            Show
            Parejkoj John Parejko added a comment - Krzysztof Findeisen can you please review the C++ changes in the first two commits here? Chris Morrison can you please review the jupyter notebooks? I'm not sure the best way to go about that, but you can view them inline in github with the View button.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Since it seems to have slipped past the bot, the PR for this ticket is #66.

            Show
            krzys Krzysztof Findeisen added a comment - Since it seems to have slipped past the bot, the PR for this ticket is #66 .
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27375/pipeline

            Show
            Parejkoj John Parejko added a comment - Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27375/pipeline
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Looks good.

            Show
            krzys Krzysztof Findeisen added a comment - Looks good.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            New Jenkins run, now with less failing OSX: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27385/pipeline

            Show
            Parejkoj John Parejko added a comment - New Jenkins run, now with less failing OSX: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27385/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Maybe this one won't explode? https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27396/pipeline

            Show
            Parejkoj John Parejko added a comment - Maybe this one won't explode? https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27396/pipeline
            Hide
            Permalink
            cmorrison Chris Morrison added a comment -

            After chatting with John Parejko, we agreed on the level of documentation needed for the Jupyter notebooks included in this ticket.

            Show
            cmorrison Chris Morrison added a comment - After chatting with  John Parejko , we agreed on the level of documentation needed for the Jupyter notebooks included in this ticket.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the reviews, Krzysztof Findeisen and Chris Morrison. I cleared up the documentation in the notebooks and the new plotting script. I think it's all quite a bit better now.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the reviews, Krzysztof Findeisen and Chris Morrison . I cleared up the documentation in the notebooks and the new plotting script. I think it's all quite a bit better now. Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Chris Morrison
              Watchers:
              Chris Morrison, John Parejko, John Swinbank, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: