Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13270

cherry pick ccdImage method cleanups from DM-9071

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      AP S18-2, AP S18-3
    • Team:
      Alert Production

      Description

      I made a number of cleanups of method names in DM-9071, in this commit:

      https://github.com/lsst/jointcal/commit/9efc5d23808b5e6f33d69e7ccd9bcf6c0bc844cb

      These should be picked out of that ticket and pushed to master.

        Attachments

          Issue Links

          has to be done before

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13976 Rename jointcal.gtransfo

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Agreed per 2018-04-05 that this is on the backburner for now.

            Show
            swinbank John Swinbank added a comment - Agreed per 2018-04-05 that this is on the backburner for now.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29072/pipeline

            Show
            Parejkoj John Parejko added a comment - jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29072/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Christopher Waters: do you mind taking on this medium sized review? It's just changes to names that match our standards and/or aren't abbreviations, so it should be both a fairly mechanical review, and a cross-eye inducing one.

            Show
            Parejkoj John Parejko added a comment - Christopher Waters : do you mind taking on this medium sized review? It's just changes to names that match our standards and/or aren't abbreviations, so it should be both a fairly mechanical review, and a cross-eye inducing one.
            Hide
            Permalink
            czw Christopher Waters added a comment -

            I'll take a look and try to get comments back today or tomorrow.

            Show
            czw Christopher Waters added a comment - I'll take a look and try to get comments back today or tomorrow.
            Hide
            Permalink
            czw Christopher Waters added a comment -

            I don't see any major issues, but there are a few things that seem to be inconsistent.  I've noted those places on the pull request.  I'm happy either way, I just wanted to know if there was a reason some names weren't changed.

            Show
            czw Christopher Waters added a comment - I don't see any major issues, but there are a few things that seem to be inconsistent.  I've noted those places on the pull request.  I'm happy either way, I just wanted to know if there was a reason some names weren't changed.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the quick review and for catching a few of the things I'd missed while iterating on this.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the quick review and for catching a few of the things I'd missed while iterating on this. Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Christopher Waters
              Watchers:
              Christopher Waters, John Parejko, John Swinbank
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.