Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13300

Add sourceCatalog method for adding multiple empty records

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      2

      Description

      Currently, to add multiple new empty records to a sourceCatalog requires multiple calls to catalog.addNew(), which can result in the catalog being non-contiguous in memory. It would be much better to have an catalog.addNew(size_t N) method that creates N new elements at once, all contiguous.

      Whether this is best done via an overload of addNew or a new method, I leave to the implementer.

        Attachments

          Issue Links

          duplicates

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-19461 Investigate and possibly fix afw::table Record allocation performance`

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            price Paul Price added a comment - - edited

            Workaround:

            catalog.reserve(num)
            		 
            for ii in range(num):
            		 
                catalog.addNew()

            Show
            price Paul Price added a comment - - edited Workaround: catalog.reserve(num) for ii in range(num): catalog.addNew()
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            What do we want to do with this old ticket? Is the workaround from Paul Price sufficient?

            Show
            tjenness Tim Jenness added a comment - What do we want to do with this old ticket? Is the workaround from Paul Price sufficient?
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            This has been fixed at some point, there was a resize method which does this exact operation. How do we mark this ticket then?

            Show
            erykoff Eli Rykoff added a comment - This has been fixed at some point, there was a resize method which does this exact operation. How do we mark this ticket then?
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            Added with DM-19461.

            Show
            erykoff Eli Rykoff added a comment - Added with DM-19461 .

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Eli Rykoff, Jim Bosch, John Parejko, John Swinbank, Paul Price, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.