Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13358

Add support for composites to Datastore prototype

    Details

      Attachments

        Issue Links

          Activity

          Hide
          tjenness Tim Jenness added a comment -

          I didn't know about "<<", I was thinking of adding isa: Exposure list of explicit subclasses and then passing those to the constructor, thereby building up the class hierarchy of StorageClass in python code. I was not going to do it through merging of configs because I don't think that helps with the case of defining ExposureI in terms of Exposure. It looks like "<<" would work for this so I think I need to work out if python knowing the StorageClass hierarchy is useful or if "<<" would be sufficient for people at the risk of less clarity. Obviously YAML comes for free so both schemes could be implemented and we can't stop people using "<<".

          Show
          tjenness Tim Jenness added a comment - I didn't know about "<<", I was thinking of adding isa: Exposure list of explicit subclasses and then passing those to the constructor, thereby building up the class hierarchy of StorageClass in python code. I was not going to do it through merging of configs because I don't think that helps with the case of defining ExposureI in terms of Exposure . It looks like "<<" would work for this so I think I need to work out if python knowing the StorageClass hierarchy is useful or if "<<" would be sufficient for people at the risk of less clarity. Obviously YAML comes for free so both schemes could be implemented and we can't stop people using "<<".
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          Some comments on PR. The main questions I have are on having StorageClass sub-classes vs instances and the necessity of having Components as a class.
          Also it is important to note that we do expect composites to still change a lot based on earlier discussions with Jim Bosch and Michelle Gower, but this should be done on future tickets.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Some comments on PR. The main questions I have are on having StorageClass sub-classes vs instances and the necessity of having Components as a class. Also it is important to note that we do expect composites to still change a lot based on earlier discussions with Jim Bosch and Michelle Gower , but this should be done on future tickets.
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          See previous comments.

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - See previous comments.
          Hide
          tjenness Tim Jenness added a comment -

          Pim Schellart [X] I think I've dealt with your comments. In particular Assemblers are now hierarchical (works much better) and know their own storage class. StorageClasses always were returned as an instance but I've now removed the metaclass so lazy loading can only be done by an instance.

          I propose we defer more discussion of URIs and filenaming to another ticket because it seems clear that we are going to change it all.

          Show
          tjenness Tim Jenness added a comment - Pim Schellart [X] I think I've dealt with your comments. In particular Assemblers are now hierarchical (works much better) and know their own storage class. StorageClasses always were returned as an instance but I've now removed the metaclass so lazy loading can only be done by an instance. I propose we defer more discussion of URIs and filenaming to another ticket because it seems clear that we are going to change it all.
          Hide
          tjenness Tim Jenness added a comment -

          Pim Schellart [X] has approved these changes on Slack.

          Show
          tjenness Tim Jenness added a comment - Pim Schellart [X] has approved these changes on Slack.

            People

            • Assignee:
              tjenness Tim Jenness
              Reporter:
              pschella Pim Schellart [X] (Inactive)
              Reviewers:
              Pim Schellart [X] (Inactive)
              Watchers:
              Jim Bosch, Pim Schellart [X] (Inactive), Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel