Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13380

Add base_PixelFlags_flag_inexact_psfCenter

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base, pipe_tasks
    • Labels:
    • Team:
      External

      Description

      The INEXACT_PSF area can be wide, so it might be helpful to be able to distinguish between sources whose footprints just touch this mask, and those whose PSFs are well and truly ruined. For other pixel flags, we use the "center" feature (which checks a 3x3 area around the object center); we should do the same for base_PixelFlags_flag_inexact_psf.

        Attachments

          Activity

          Hide
          price Paul Price added a comment -

          price@pap-laptop:~/LSST/meas_base (tickets/DM-13380 $=) $ git sub-patch
          commit 86605131e9ccc2089721c3a38bb05cc45f9a3b61 (HEAD -> tickets/DM-13380, origin/tickets/DM-13380)
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Fri Jan 26 16:49:50 2018 -0500
           
              forcedPhotCoadd: flag sources with central INEXACT_PSF
              
              The CLIPPED/INEXACT_PSF area can be wide, so it will likely be
              helpful to be able to distinguish between sources whose footprints
              just touch this mask, and those whose cores are well and truly
              ruined.
           
          diff --git a/python/lsst/meas/base/forcedPhotCoadd.py b/python/lsst/meas/base/forcedPhotCoadd.py
          index 6f7dfb2..04f588b 100644
          --- a/python/lsst/meas/base/forcedPhotCoadd.py
          +++ b/python/lsst/meas/base/forcedPhotCoadd.py
          @@ -53,6 +53,8 @@ class ForcedPhotCoaddConfig(ForcedPhotImageConfig):
                   self.measurement.plugins.names |= ['base_InputCount', 'base_Variance']
                   self.measurement.plugins['base_PixelFlags'].masksFpAnywhere = ['CLIPPED', 'SENSOR_EDGE',
                                                                                  'INEXACT_PSF']
          +        self.measurement.plugins['base_PixelFlags'].masksFpCenter = ['CLIPPED', 'SENSOR_EDGE',
          +                                                                     'INEXACT_PSF']
           
               def validate(self):
                   ForcedPhotImageTask.ConfigClass.validate(self)
           
           
          price@pap-laptop:~/LSST/pipe_tasks (tickets/DM-13380=) $ git sub-patch
          commit 002a00139fad9517a118389918c20624ffbf4714 (HEAD -> tickets/DM-13380, origin/tickets/DM-13380)
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Fri Jan 26 16:50:24 2018 -0500
           
              measureCoaddSources: flag sources with central INEXACT_PSF
              
              The CLIPPED/INEXACT_PSF area can be wide, so it will likely be
              helpful to be able to distinguish between sources whose footprints
              just touch this mask, and those whose cores are well and truly
              ruined.
           
          diff --git a/python/lsst/pipe/tasks/multiBand.py b/python/lsst/pipe/tasks/multiBand.py
          index 41509df4..11099d6d 100644
          --- a/python/lsst/pipe/tasks/multiBand.py
          +++ b/python/lsst/pipe/tasks/multiBand.py
          @@ -871,6 +871,8 @@ class MeasureMergedCoaddSourcesConfig(Config):
                   self.measurement.plugins.names |= ['base_InputCount', 'base_Variance']
                   self.measurement.plugins['base_PixelFlags'].masksFpAnywhere = ['CLIPPED', 'SENSOR_EDGE',
                                                                                  'INEXACT_PSF']
          +        self.measurement.plugins['base_PixelFlags'].masksFpCenter = ['CLIPPED', 'SENSOR_EDGE',
          +                                                                     'INEXACT_PSF']
           
           ## \addtogroup LSST_task_documentation
           ## \{
          

          Show
          price Paul Price added a comment - price@pap-laptop:~/LSST/meas_base (tickets/DM-13380 $=) $ git sub-patch commit 86605131e9ccc2089721c3a38bb05cc45f9a3b61 (HEAD -> tickets/DM-13380, origin/tickets/DM-13380) Author: Paul Price <price@astro.princeton.edu> Date: Fri Jan 26 16:49:50 2018 -0500   forcedPhotCoadd: flag sources with central INEXACT_PSF The CLIPPED/INEXACT_PSF area can be wide, so it will likely be helpful to be able to distinguish between sources whose footprints just touch this mask, and those whose cores are well and truly ruined.   diff --git a/python/lsst/meas/base/forcedPhotCoadd.py b/python/lsst/meas/base/forcedPhotCoadd.py index 6f7dfb2..04f588b 100644 --- a/python/lsst/meas/base/forcedPhotCoadd.py +++ b/python/lsst/meas/base/forcedPhotCoadd.py @@ -53,6 +53,8 @@ class ForcedPhotCoaddConfig(ForcedPhotImageConfig): self.measurement.plugins.names |= ['base_InputCount', 'base_Variance'] self.measurement.plugins['base_PixelFlags'].masksFpAnywhere = ['CLIPPED', 'SENSOR_EDGE', 'INEXACT_PSF'] + self.measurement.plugins['base_PixelFlags'].masksFpCenter = ['CLIPPED', 'SENSOR_EDGE', + 'INEXACT_PSF'] def validate(self): ForcedPhotImageTask.ConfigClass.validate(self)     price@pap-laptop:~/LSST/pipe_tasks (tickets/DM-13380=) $ git sub-patch commit 002a00139fad9517a118389918c20624ffbf4714 (HEAD -> tickets/DM-13380, origin/tickets/DM-13380) Author: Paul Price <price@astro.princeton.edu> Date: Fri Jan 26 16:50:24 2018 -0500   measureCoaddSources: flag sources with central INEXACT_PSF The CLIPPED/INEXACT_PSF area can be wide, so it will likely be helpful to be able to distinguish between sources whose footprints just touch this mask, and those whose cores are well and truly ruined.   diff --git a/python/lsst/pipe/tasks/multiBand.py b/python/lsst/pipe/tasks/multiBand.py index 41509df4..11099d6d 100644 --- a/python/lsst/pipe/tasks/multiBand.py +++ b/python/lsst/pipe/tasks/multiBand.py @@ -871,6 +871,8 @@ class MeasureMergedCoaddSourcesConfig(Config): self.measurement.plugins.names |= ['base_InputCount', 'base_Variance'] self.measurement.plugins['base_PixelFlags'].masksFpAnywhere = ['CLIPPED', 'SENSOR_EDGE', 'INEXACT_PSF'] + self.measurement.plugins['base_PixelFlags'].masksFpCenter = ['CLIPPED', 'SENSOR_EDGE', + 'INEXACT_PSF'] ## \addtogroup LSST_task_documentation ## \{
          Hide
          price Paul Price added a comment - - edited

          Jim Bosch, would you mind reviewing this while I run Jenkins?

          Show
          price Paul Price added a comment - - edited Jim Bosch , would you mind reviewing this while I run Jenkins ?
          Hide
          jbosch Jim Bosch added a comment -

          Looks good!

          Show
          jbosch Jim Bosch added a comment - Looks good!
          Hide
          price Paul Price added a comment -

          Jenkins is green.

          Show
          price Paul Price added a comment - Jenkins is green.
          Hide
          price Paul Price added a comment -

          Thanks Jim.

          Merged to master.

          Show
          price Paul Price added a comment - Thanks Jim. Merged to master.

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, Paul Price
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel