Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13385

Remove unnecessary virtual destructors

    XMLWordPrintable

    Details

    • Type: Story
    • Status: In Progress
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      1
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      In the course of the review of DM-9932, I noticed a number of classes with virtual destructors that probably don't need them (I think just due to the paranoia many new C++ developers have when they first learn about destructors; these are all very old classes). Fixing that is out of scope for DM-9932, but we should eventually look more carefully at each case and then remove them.

      The classes in question:

      • Exposure
      • ImagePca
      • ImageBase
      • Image
      • Mask
      • BackgroundControl

        Attachments

          Issue Links

            Activity

            Hide
            wittgen Matthias Wittgen added a comment - - edited

            You are correct. This is not ready yet as this is more complex and needs evaluation of usages in other repos.

            Show
            wittgen Matthias Wittgen added a comment - - edited You are correct. This is not ready yet as this is more complex and needs evaluation of usages in other repos.
            Hide
            krzys Krzysztof Findeisen added a comment -

            Can you explain what criteria you're using? ImageBase is a particularly odd choice since (as the name implies) it's intended for use as a base class.

            Show
            krzys Krzysztof Findeisen added a comment - Can you explain what criteria you're using? ImageBase is a particularly odd choice since (as the name implies) it's intended for use as a base class.
            Hide
            wittgen Matthias Wittgen added a comment -
            • Exposure
            • ImagePca
            • ImageBase
            • ImageSlice
            • Image
            • Mask
            • BackgroundControl

            don't need virtual dtors, needed to remove some virtual operators/member functions.

            Show
            wittgen Matthias Wittgen added a comment - Exposure ImagePca ImageBase ImageSlice Image Mask BackgroundControl don't need virtual dtors, needed to remove some virtual operators/member functions.
            Hide
            wittgen Matthias Wittgen added a comment -

            I'll check.

            Show
            wittgen Matthias Wittgen added a comment - I'll check.
            Hide
            tjenness Tim Jenness added a comment -

            Have these all been cleaned up? I know that Matthias Wittgen has been doing lots of cleanups in afw.

            Show
            tjenness Tim Jenness added a comment - Have these all been cleaned up? I know that Matthias Wittgen has been doing lots of cleanups in afw.

              People

              Assignee:
              wittgen Matthias Wittgen
              Reporter:
              jbosch Jim Bosch
              Watchers:
              Jim Bosch, Krzysztof Findeisen, Matthias Wittgen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins Builds

                  No builds found.