Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13389

Enable transmission curve attachment for HSC by default

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None

      Description

      Set

      self.doAttachTransmissionCurve = True

      in SubaruIsrTask.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            This trivial change just enables the functionality added on DM-12375 by default (for HSC):

            Author: Jim Bosch <jbosch@astro.princeton.edu>
            Date: Fri Jan 26 13:42:15 2018 -0500
             
            Enable attaching TransmissionCurves by default.
             
            diff --git a/python/lsst/obs/subaru/isr.py b/python/lsst/obs/subaru/isr.py
            index 11588c9d..4fbe12f0 100644
            --- a/python/lsst/obs/subaru/isr.py
            +++ b/python/lsst/obs/subaru/isr.py
            @@ -194,6 +194,9 @@ after applying the nominal gain
            thumbnailQ = Field(dtype=float, default=20.0, doc="Softening parameter for thumbnail mapping")
            thumbnailSatBorder = Field(dtype=int, default=2, doc="Border around saturated pixels for thumbnail")
             
            + def setDefaults(self):
            + self.doAttachTransmissionCurve = True
            +
            def validate(self):
            super(SubaruIsrConfig, self).validate()
            if self.doFlat and self.doApplyGains:
            

            I'll have a community post announcing the change ready by the time I merge.

             

            Show
            jbosch Jim Bosch added a comment - This trivial change just enables the functionality added on DM-12375 by default (for HSC): Author: Jim Bosch <jbosch @astro .princeton.edu> Date: Fri Jan 26 13 : 42 : 15 2018 - 0500   Enable attaching TransmissionCurves by default .   diff --git a/python/lsst/obs/subaru/isr.py b/python/lsst/obs/subaru/isr.py index 11588c9d..4fbe12f0 100644 --- a/python/lsst/obs/subaru/isr.py +++ b/python/lsst/obs/subaru/isr.py @@ - 194 , 6 + 194 , 9 @@ after applying the nominal gain thumbnailQ = Field(dtype= float , default = 20.0 , doc= "Softening parameter for thumbnail mapping" ) thumbnailSatBorder = Field(dtype= int , default = 2 , doc= "Border around saturated pixels for thumbnail" )   + def setDefaults(self): + self.doAttachTransmissionCurve = True + def validate(self): super (SubaruIsrConfig, self).validate() if self.doFlat and self.doApplyGains: I'll have a community post announcing the change ready by the time I merge.  
            Hide
            price Paul Price added a comment -

            Great!

            Show
            price Paul Price added a comment - Great!
            Hide
            jbosch Jim Bosch added a comment -

            Merged to master.

            Show
            jbosch Jim Bosch added a comment - Merged to master.

              People

              • Assignee:
                jbosch Jim Bosch
                Reporter:
                jbosch Jim Bosch
                Reviewers:
                Paul Price
                Watchers:
                Jim Bosch, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: