# Drop GaussianCentroid

XMLWordPrintable

## Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Team:
External

## Description

Following approval of RFC-437, drop GaussianCentroid.

## Activity

Hide
John Parejko added a comment -

Code reviews consisting (almost) entirely of red are the best code reviews.

Searching my stack, I see GaussianCentroid used in ip_diffim in a few places too: that one should be cleared up. Also one file in obs_subaru, and in my jointcal config/processCcd.py, which shouldn't matter.

Show
John Parejko added a comment - Code reviews consisting (almost) entirely of red are the best code reviews. Searching my stack, I see GaussianCentroid used in ip_diffim in a few places too: that one should be cleared up. Also one file in obs_subaru, and in my jointcal config/processCcd.py, which shouldn't matter.
Hide
Paul Price added a comment -

I don't remember seeing ip_diffim in my GitHub search, but I've fixed that up: https://github.com/lsst/ip_diffim/pull/79
The file in obs_subaru with GaussianCentroid is a mapping, so I don't think it matters if the column no longer exists.

Show
Paul Price added a comment - I don't remember seeing ip_diffim in my GitHub search, but I've fixed that up: https://github.com/lsst/ip_diffim/pull/79 The file in obs_subaru with GaussianCentroid is a mapping, so I don't think it matters if the column no longer exists.
Hide
John Parejko added a comment -

Looks good. Probably re-run jenkins after the ip_diffim change. Thanks!

Show
John Parejko added a comment - Looks good. Probably re-run jenkins after the ip_diffim change. Thanks!
Hide
Paul Price added a comment -

Jenkins went through fine except for one afw failure in FITS compression that appears to be sporadic; I've filed DM-13462 to look into that, but I think this work is good.

Show
Paul Price added a comment - Jenkins went through fine except for one afw failure in FITS compression that appears to be sporadic; I've filed DM-13462 to look into that, but I think this work is good.
Hide
Paul Price added a comment -

Thanks John Parejko!

Merged to master.

Show
Paul Price added a comment - Thanks John Parejko ! Merged to master.

## People

• Assignee:
Paul Price
Reporter:
Paul Price
Reviewers:
John Parejko
Watchers:
John Parejko, Paul Price