Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13395

Drop GaussianCentroid

    XMLWordPrintable

    Details

    • Team:
      External

      Description

      Following approval of RFC-437, drop GaussianCentroid.

        Attachments

          Issue Links

          is duplicated by

          Improvement - An improvement or enhancement to an existing feature or task. DM-2259 remove PSFAttributes

          • Invalid
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-437 Drop GaussianCentroid

          • Implemented
          mitigates

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-1014 Detailed documentation for GaussianCentroid

          • Invalid

          Improvement - An improvement or enhancement to an existing feature or task. DM-2368 GaussianCentroid should set an error

          • Invalid
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13299 Make pipe_tasks/tests/nopytest_test_coadds.py valgrind-clean

          • Invalid

          Improvement - An improvement or enhancement to an existing feature or task. DM-2259 remove PSFAttributes

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            5 older comments
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Code reviews consisting (almost) entirely of red are the best code reviews.

            Searching my stack, I see GaussianCentroid used in ip_diffim in a few places too: that one should be cleared up. Also one file in obs_subaru, and in my jointcal `config/processCcd.py`, which shouldn't matter.

            Show
            Parejkoj John Parejko added a comment - Code reviews consisting (almost) entirely of red are the best code reviews. Searching my stack, I see GaussianCentroid used in ip_diffim in a few places too: that one should be cleared up. Also one file in obs_subaru, and in my jointcal `config/processCcd.py`, which shouldn't matter.
            Hide
            Permalink
            price Paul Price added a comment -

            I don't remember seeing ip_diffim in my GitHub search, but I've fixed that up: https://github.com/lsst/ip_diffim/pull/79
            The file in obs_subaru with GaussianCentroid is a mapping, so I don't think it matters if the column no longer exists.

            Show
            price Paul Price added a comment - I don't remember seeing ip_diffim in my GitHub search, but I've fixed that up: https://github.com/lsst/ip_diffim/pull/79 The file in obs_subaru with GaussianCentroid is a mapping, so I don't think it matters if the column no longer exists.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Looks good. Probably re-run jenkins after the ip_diffim change. Thanks!

            Show
            Parejkoj John Parejko added a comment - Looks good. Probably re-run jenkins after the ip_diffim change. Thanks!
            Hide
            Permalink
            price Paul Price added a comment -

            Jenkins went through fine except for one afw failure in FITS compression that appears to be sporadic; I've filed DM-13462 to look into that, but I think this work is good.

            Show
            price Paul Price added a comment - Jenkins went through fine except for one afw failure in FITS compression that appears to be sporadic; I've filed DM-13462 to look into that, but I think this work is good.
            Hide
            Permalink
            price Paul Price added a comment -

            Thanks John Parejko!

            Merged to master.

            Show
            price Paul Price added a comment - Thanks John Parejko ! Merged to master.

              People

              Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              John Parejko
              Watchers:
              John Parejko, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.