Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13395

Drop GaussianCentroid

    XMLWordPrintable

    Details

    • Team:
      External

      Description

      Following approval of RFC-437, drop GaussianCentroid.

        Attachments

          Issue Links

          is duplicated by

          Improvement - An improvement or enhancement to an existing feature or task. DM-2259 remove PSFAttributes

          • Invalid
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-437 Drop GaussianCentroid

          • Implemented
          mitigates

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-1014 Detailed documentation for GaussianCentroid

          • Invalid

          Improvement - An improvement or enhancement to an existing feature or task. DM-2368 GaussianCentroid should set an error

          • Invalid
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13299 Make pipe_tasks/tests/nopytest_test_coadds.py valgrind-clean

          • Invalid

          Improvement - An improvement or enhancement to an existing feature or task. DM-2259 remove PSFAttributes

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            price Paul Price created issue -
            price Paul Price made changes -
            Field Original Value New Value
            Link This issue is triggered by RFC-437 [ RFC-437 ]
            Hide
            Permalink
            price Paul Price added a comment -

            This requires dropping PsfAttributes from meas_algorithms as well, since it uses GaussianCentroid.

            Show
            price Paul Price added a comment - This requires dropping PsfAttributes from meas_algorithms as well, since it uses GaussianCentroid .
            price Paul Price made changes -
            Link This issue relates to DM-2259 [ DM-2259 ]
            Hide
            Permalink
            price Paul Price added a comment -

            There was an RFC for dropping PsfAttributes sent to lsst-data by Jim Bosch on 2015-05-30 (probably before RFCs started on Jira). I don't see any dissent, and there's a ticket on Jira for dropping it (DM-2259).

            Show
            price Paul Price added a comment - There was an RFC for dropping PsfAttributes sent to lsst-data by Jim Bosch on 2015-05-30 (probably before RFCs started on Jira). I don't see any dissent, and there's a ticket on Jira for dropping it ( DM-2259 ).
            price Paul Price made changes -
            Link This issue relates to DM-13299 [ DM-13299 ]
            Hide
            Permalink
            price Paul Price added a comment -

            Jenkins is green.

            Show
            price Paul Price added a comment - Jenkins is green.
            Hide
            Permalink
            price Paul Price added a comment -

            John Parejko, as chief rejoicer in removed code, would you mind having a look at this, please?

            Show
            price Paul Price added a comment - John Parejko , as chief rejoicer in removed code, would you mind having a look at this, please?
            price Paul Price made changes -
            Reviewers John Parejko [ parejkoj ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            price Paul Price made changes -
            Component/s meas_algorithms [ 10732 ]
            Hide
            Permalink
            price Paul Price added a comment -

            GitHub:

            Show
            price Paul Price added a comment - GitHub: https://github.com/lsst/meas_algorithms/pull/101 https://github.com/lsst/meas_base/pull/106
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Code reviews consisting (almost) entirely of red are the best code reviews.

            Searching my stack, I see GaussianCentroid used in ip_diffim in a few places too: that one should be cleared up. Also one file in obs_subaru, and in my jointcal `config/processCcd.py`, which shouldn't matter.

            Show
            Parejkoj John Parejko added a comment - Code reviews consisting (almost) entirely of red are the best code reviews. Searching my stack, I see GaussianCentroid used in ip_diffim in a few places too: that one should be cleared up. Also one file in obs_subaru, and in my jointcal `config/processCcd.py`, which shouldn't matter.
            Parejkoj John Parejko made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            Permalink
            price Paul Price added a comment -

            I don't remember seeing ip_diffim in my GitHub search, but I've fixed that up: https://github.com/lsst/ip_diffim/pull/79
            The file in obs_subaru with GaussianCentroid is a mapping, so I don't think it matters if the column no longer exists.

            Show
            price Paul Price added a comment - I don't remember seeing ip_diffim in my GitHub search, but I've fixed that up: https://github.com/lsst/ip_diffim/pull/79 The file in obs_subaru with GaussianCentroid is a mapping, so I don't think it matters if the column no longer exists.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Looks good. Probably re-run jenkins after the ip_diffim change. Thanks!

            Show
            Parejkoj John Parejko added a comment - Looks good. Probably re-run jenkins after the ip_diffim change. Thanks!
            Hide
            Permalink
            price Paul Price added a comment -

            Jenkins went through fine except for one afw failure in FITS compression that appears to be sporadic; I've filed DM-13462 to look into that, but I think this work is good.

            Show
            price Paul Price added a comment - Jenkins went through fine except for one afw failure in FITS compression that appears to be sporadic; I've filed DM-13462 to look into that, but I think this work is good.
            price Paul Price made changes -
            Component/s ip_diffim [ 10743 ]
            Hide
            Permalink
            price Paul Price added a comment -

            Thanks John Parejko!

            Merged to master.

            Show
            price Paul Price added a comment - Thanks John Parejko ! Merged to master.
            price Paul Price made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            tjenness Tim Jenness made changes -
            Link This issue mitigates DM-2368 [ DM-2368 ]
            tjenness Tim Jenness made changes -
            Link This issue mitigates DM-1014 [ DM-1014 ]
            tjenness Tim Jenness made changes -
            Link This issue relates to DM-2259 [ DM-2259 ]
            jbosch Jim Bosch made changes -
            Link This issue relates to DM-2259 [ DM-2259 ]
            jbosch Jim Bosch made changes -
            Link This issue is duplicated by DM-2259 [ DM-2259 ]

              People

              Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              John Parejko
              Watchers:
              John Parejko, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.