Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13410

Shrink input bboxes in inputRecorder per psfMatched Warp in WarpCompare

    Details

      Description

      WarpCompare has no temporal information for the pixels that are outside the boundary of the psfMatched Warps. These pixels are marked NO_DATA. The BBoxes in the CoaddInputRecorder should be shrunk so that we can have an exact CoaddPsf for sources that fall in the border of calexp. 

        Attachments

          Issue Links

            Activity

            Hide
            yusra Yusra AlSayyad added a comment -

            I know its  late in the day.  I could ask a west coaster.  Also, I don't have my heart set on merging before the  w_2018_07 tag.

            Show
            yusra Yusra AlSayyad added a comment - I know its  late in the day.  I could ask a west coaster.  Also, I don't have my heart set on merging before the  w_2018_07 tag.
            Hide
            yusra Yusra AlSayyad added a comment -

            Note to self; eventually I want to save the matchingKernel  so that assembleCoadd has access to it (to use for detection on the warpDiffs). We could  extract its size, instead of requiring that the matchingKernelSize configs match. 

            Show
            yusra Yusra AlSayyad added a comment - Note to self; eventually I want to save the matchingKernel  so that assembleCoadd has access to it (to use for detection on the warpDiffs). We could  extract its size, instead of requiring that the matchingKernelSize configs match. 
            Hide
            price Paul Price added a comment -

            Comments from the review are on the PRs, and consist mostly of suggestions for structural improvements.

            Show
            price Paul Price added a comment - Comments from the review are on the PRs, and consist mostly of suggestions for structural improvements.
            Hide
            yusra Yusra AlSayyad added a comment - - edited

            Addressed all issues except 

            • the warpAndPsfMatch.psfMatch.config. I do need to set it from here. I understand what you're saying but I think the solution is getting rid of warpAndPsfMatchTask, which I don't want to do right now. 

             * the assembleStaticSky.badMaskPlanes=[NO_DATA], was from ensuring the SOMETHING was in the WIDE template coadd (fixing DM-12697), I'll run a test with + BAD, SAT to be sure.

            • tickets/DM-13410 running jenkins now. 
            • made a u/yusra/DM-13410 which has a copy of the ticket post review rebase, but pre SkyWcs rebase, in case I need a copy for testing with this version of the stack. 
            Show
            yusra Yusra AlSayyad added a comment - - edited Addressed all issues except  the warpAndPsfMatch.psfMatch.config. I do need to set it from here. I understand what you're saying but I think the solution is getting rid of warpAndPsfMatchTask, which I don't want to do right now.   * the assembleStaticSky.badMaskPlanes= [NO_DATA] , was from ensuring the SOMETHING was in the WIDE template coadd (fixing DM-12697 ), I'll run a test with + BAD, SAT to be sure. tickets/ DM-13410 running jenkins now.  made a u/yusra/ DM-13410 which has a copy of the ticket post review rebase, but pre SkyWcs rebase, in case I need a copy for testing with this version of the stack. 
            Hide
            yusra Yusra AlSayyad added a comment -

            Merged. Before and after shots of INEXACT_PSF  and SENSOR_EDGE.  SENSOR_EDGE difference is harder to see: the egdes have moved in towards the center of each ccd by 14 pixels,.

            Before from /datasets/hsc/repo/rerun/RC/w_2018_06/DM-13435 and after from /datasets/hsc/repo/rerun/private/yusra/RC/DM-13410-mask

            Show
            yusra Yusra AlSayyad added a comment - Merged. Before and after shots of INEXACT_PSF  and SENSOR_EDGE.  SENSOR_EDGE difference is harder to see: the egdes have moved in towards the center of each ccd by 14 pixels,. Before from  /datasets/hsc/repo/rerun/RC/w_2018_06/ DM-13435 and after from /datasets/hsc/repo/rerun/private/yusra/RC/ DM-13410 -mask

              People

              • Assignee:
                yusra Yusra AlSayyad
                Reporter:
                yusra Yusra AlSayyad
                Reviewers:
                Paul Price
                Watchers:
                Jim Bosch, Paul Price, Yusra AlSayyad
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel