Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13411

Fix compiler warnings in TransmissionCurve implementation

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      0.25
    • Sprint:
      DRP S18-2
    • Team:
      Data Release Production

      Description

      From Russell Owen:

      src/image/TransmissionCurve.cc:93:46: warning: ‘_multipliedByImpl’ overrides a member function but is not marked ‘override’ [-Winconsistent-missing-override]
      std::shared_ptr<TransmissionCurve const> _multipliedByImpl(
      ^
      include/lsst/afw/image/TransmissionCurve.h:237:54: note: overridden virtual function is here
      virtual std::shared_ptr<TransmissionCurve const> _multipliedByImpl(
      ^
      src/image/TransmissionCurve.cc:587:10: warning: ‘write’ overrides a member function but is not marked ‘override’ [-Winconsistent-missing-override]
      void write(OutputArchiveHandle & handle) const {
      ^
      include/lsst/afw/table/io/Persistable.h:134:18: note: overridden virtual function is here
      virtual void write(OutputArchiveHandle& handle) const;
      ^
      src/image/TransmissionCurve.cc:676:10: warning: ‘write’ overrides a member function but is not marked ‘override’ [-Winconsistent-missing-override]
      void write(OutputArchiveHandle & handle) const {
      ^
      include/lsst/afw/table/io/Persistable.h:134:18: note: overridden virtual function is here
      virtual void write(OutputArchiveHandle& handle) const;
      ^
      

        Attachments

          Activity

          Hide
          jbosch Jim Bosch added a comment -

          Russell Owen, as punishment for finding my mistake, mind reviewing the fix?

          https://github.com/lsst/afw/pull/315/files

           

          Show
          jbosch Jim Bosch added a comment - Russell Owen , as punishment for finding my mistake, mind reviewing the fix? https://github.com/lsst/afw/pull/315/files  
          Hide
          rowen Russell Owen added a comment -

          Looks perfect. Thanks for the quick fix!

          Show
          rowen Russell Owen added a comment - Looks perfect. Thanks for the quick fix!
          Hide
          jbosch Jim Bosch added a comment -

          Merged to master.

          Show
          jbosch Jim Bosch added a comment - Merged to master.

            People

            • Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Russell Owen
              Watchers:
              Jim Bosch, Russell Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel