Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: Firefly
-
Labels:
-
Story Points:5
-
Epic Link:
-
Sprint:SUIT Sprint 2018-03
-
Team:Science User Interface
Description
From DM-13203 item 1, 4, 5.
- Generate a meaningful error message when a column filter expression applied to a table is invalid. This may not require any extra parsing effort for the filter expressions - the system knows the name of the column and the text typed in the filter field, and can just wrap the underlying error message with something like "The filter expression 'xyzzy' applied to column 'foobar' is invalid.". For the purposes of debugging it may be useful to provide a UI action (e.g., a disclosure triangle) that makes it possible to see the full underlying exception text.
- Ensure that, when an invalid filter expression is entered, after dismissing the error message the user is returned to the same state of their data and previously-specified filters as before the failed attempt to construct a filter. This does not require arbitrary undos, but only that the displayed state of the table is not changed before the filter has been determined to be valid.
- Do not use the word "Reload" for the button that dismisses the error dialog. "Back", "Close", "Cancel" would all be better choices. Consider asking for feedback from others, e.g., Vandana, for this choice. "Reload" strongly suggests - to me - that the underlying data retrieval operation would be repeated rather than just abandoning the filter attempt.
We should ask Vandana to test the fixes (PR) as she is mentioned also here in item 5.