Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13492

Remove --rerun argument for ap_verify

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      AP F18-1, AP F18-2
    • Team:
      Alert Production

      Description

      Nobody remembers why --rerun was originally added to ap_verify's command-line interface; see discussion on DM-12853. In the absence of a compelling case for it (it cannot behave exactly like the --rerun argument for command line tasks, because ap_verify does not have an input repository), and given its currently confusing behavior, we should remove --rerun from the ap_verify API. It can be added back once we have a clear expectation of how it should behave.

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-13163 Refactor ap_pipe to use CmdLineTask primitives

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-12853 Review design questions in ap_verify

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            I don't disagree with Simon's suggestion here, but let's discuss this ticket and whether it's something we really want to do before working on it; I'm not sure I understand all the ramifications, and would like to see where it fits in the longer-term roadmap. (Which means we need a longer term roadmap...)

            Show
            swinbank John Swinbank added a comment - I don't disagree with Simon's suggestion here, but let's discuss this ticket and whether it's something we really want to do before working on it; I'm not sure I understand all the ramifications, and would like to see where it fits in the longer-term roadmap. (Which means we need a longer term roadmap...)
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Per discussion of 2018-06-07 with Eric Bellm & Krzysztof Findeisen, we agreed to simply remove the --rerun argument until & unless somebody advances a compelling rationale for it.

            Show
            swinbank John Swinbank added a comment - Per discussion of 2018-06-07 with Eric Bellm & Krzysztof Findeisen , we agreed to simply remove the --rerun argument until & unless somebody advances a compelling rationale for it.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Hi Eric Bellm, can you review this 110-line code/documentation (mostly documentation) change? Thanks!

            Show
            krzys Krzysztof Findeisen added a comment - Hi Eric Bellm , can you review this 110-line code/documentation (mostly documentation) change? Thanks!
            Hide
            Permalink
            ebellm Eric Bellm added a comment -

            Looks great.

            Show
            ebellm Eric Bellm added a comment - Looks great.

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Eric Bellm
              Watchers:
              Eric Bellm, John Swinbank, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.