Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-13509

Some pure python packages add to LD_LIBRARY_PATH

    XMLWordPrintable

    Details

    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      AP S18-6
    • Team:
      Alert Production

      Description

      The pure python packages listed in Components have ups tables that add themselves to LD_LIBRARY_PATH and two related library paths. They should not do this. Remove the following from their ups table files:

      envPrepend(LD_LIBRARY_PATH, ${PRODUCT_DIR}/lib)
      		 
      envPrepend(DYLD_LIBRARY_PATH, ${PRODUCT_DIR}/lib)
      		 
      envPrepend(LSST_LIBRARY_PATH, ${PRODUCT_DIR}/lib)

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-13339 shebang needs to be changed in several places in bin.src directories

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment - - edited

            Perhaps we need to add instructions for configuring ups/ to the dev guide. I think the table and config files are mostly cargo-culted right now.

            Show
            krzys Krzysztof Findeisen added a comment - - edited Perhaps we need to add instructions for configuring ups/ to the dev guide. I think the table and config files are mostly cargo-culted right now.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            The `templates` package is another reasonable source of this information (and the most likely source for new packages). That said, it could use some refinement of its description of pure python packages (based on my trying to figure out the right configuration for cbp recently).

            Show
            rowen Russell Owen added a comment - The `templates` package is another reasonable source of this information (and the most likely source for new packages). That said, it could use some refinement of its description of pure python packages (based on my trying to figure out the right configuration for cbp recently).
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            The templates package does indeed contain this info in the ups table file. I hope that will suffice.

            I also updated obs_cfht as follows:

            • Remove python 2 compatibility code.
            • Move those bin scripts that have shbang lines into bin.src and enabled the usual processing of those, so they run on macOS
            • Fixed flake8 warnings (not many) and enabled automatic flake8 testing
            Show
            rowen Russell Owen added a comment - - edited The templates package does indeed contain this info in the ups table file. I hope that will suffice. I also updated obs_cfht as follows: Remove python 2 compatibility code. Move those bin scripts that have shbang lines into bin.src and enabled the usual processing of those, so they run on macOS Fixed flake8 warnings (not many) and enabled automatic flake8 testing
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            FYI Your fixes to the shebangs in obs_lsstSim were reported on DM-13339.

            Show
            tjenness Tim Jenness added a comment - FYI Your fixes to the shebangs in obs_lsstSim were reported on DM-13339 .
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Tim Jenness do you have time to look at this one?

            Show
            rowen Russell Owen added a comment - Tim Jenness do you have time to look at this one?
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks good. I had reviewed the individual PRs this morning.

            Show
            tjenness Tim Jenness added a comment - Looks good. I had reviewed the individual PRs this morning.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Tim Jenness
              Watchers:
              Krzysztof Findeisen, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.